M-Labs
/
zynq-rs
10
0
Fork 12
Code Issues 6 Pull Requests 1 Releases Wiki Activity

Modified SDIO to handle u8 buffer instead of u32. #33

Merged
sb10q merged 1 commits from pca006132/zynq-rs:sdio-fix into master 2020-06-09 17:11:04 +08:00
Conversation 0 Commits 1 Files Changed 3
pca006132 commented 2020-06-09 17:07:59 +08:00

Modified the signature from u32 to u8 slices. Tested it could handle not word-aligned read/write.

This modification is to simplify the implementation of Read and Write in core_io, as they would be using u8. Casting [u8] to [u32] would have to handle alignment issue which is a mess even if there is align_to provided...

Modified the signature from `u32` to `u8` slices. Tested it could handle not word-aligned read/write. This modification is to simplify the implementation of `Read` and `Write` in `core_io`, as they would be using `u8`. Casting `[u8]` to `[u32]` would have to handle alignment issue which is a mess even if there is `align_to` provided...
sb10q closed this pull request 2020-06-09 17:11:04 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#33
There is no content yet.
Delete Branch "pca006132/zynq-rs:sdio-fix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?