autounattend: use ForceShutdownNow instead of FirstLogonCommands shutdown #11

astro · 2021-04-18T06:58:09+08:00

astro commented

2021-04-18 06:58:09 +08:00

this moves the return a little earlier in the installation process.
it is less of a hack, and less problematic with custom defaultUser
settings.

this moves the return a little earlier in the installation process. it is less of a hack, and less problematic with custom `defaultUser` settings.

astro added 1 commit 2021-04-18 06:58:09 +08:00

autounattend: use ForceShutdownNow instead of FirstLogonCommands shutdown 54d9f41a6d

this moves the return a little earlier in the installation process.
it is less of a hack, and less problematic with custom `defaultUser`
settings.

sb10q commented

2021-04-19 14:17:41 +08:00

@astro I don't feel qualified to comment on the technical side of things here. If this is tested and works, let's merge it.

astro commented

2021-04-24 00:17:40 +08:00

As this patch shifts the OOBE pass to the next layer (DisablePasswordExpiry), that will run longer. I found it helpful to increase timeout on slower machines.

@parthy Care to test wfvm pull requests in your environment?

As this patch shifts the OOBE pass to the next layer (`DisablePasswordExpiry`), that will run longer. I found it helpful to increase [timeout](https://git.m-labs.hk/M-Labs/wfvm/src/commit/ec54c9bf9b55403c859f10cdeee9370f8d64e69e/wfvm/utils.nix#L34) on slower machines. @parthy Care to test wfvm pull requests in your environment?

parthy commented

2021-04-26 16:45:19 +08:00

Unfortunately, due to the change in ec54c9bf9b, our pipeline fails to run on this:

qemu-system-x86_64: QXL VGA not available

Unfortunately, due to the change in https://git.m-labs.hk/M-Labs/wfvm/commit/ec54c9bf9b55403c859f10cdeee9370f8d64e69e, our pipeline fails to run on this: `qemu-system-x86_64: QXL VGA not available`

astro commented

2021-04-26 22:43:23 +08:00

qemu-system-x86_64: QXL VGA not available

Do you run qemu that is built w/o support for -vga qxl? That should be fixable.

> `qemu-system-x86_64: QXL VGA not available` Do you run qemu that is built w/o support for `-vga qxl`? That should be fixable.

parthy commented

2021-04-26 22:47:19 +08:00

I'm not running any custom qemu. I think the build process just picks pkgs.qemu, or not? Is it the fact that I am running the build in a pure server environment? (GitLab pipeline, Hydra)

I'm not running any custom qemu. I think the build process just picks `pkgs.qemu`, or not? Is it the fact that I am running the build in a pure server environment? (GitLab pipeline, Hydra)

astro commented

2021-07-01 03:43:36 +08:00

@parthy The issue is that the build process contains qemu_test which seems to lack QXL by default now.

diff --git wfvm/utils.nix wfvm/utils.nix
index eb81579..e4927f7 100644
--- wfvm/utils.nix
+++ wfvm/utils.nix
@@ -2,7 +2,7 @@
 
 rec {
   # qemu_test is a smaller closure only building for a single system arch
-  qemu = pkgs.qemu_test;
+  qemu = pkgs.qemu;
 
   mkQemuFlags = extraFlags: [
     "-enable-kvm"

@parthy The issue is that the build process contains qemu_test which seems to lack QXL by default now. ```patch diff --git wfvm/utils.nix wfvm/utils.nix index eb81579..e4927f7 100644 --- wfvm/utils.nix +++ wfvm/utils.nix @@ -2,7 +2,7 @@ rec { # qemu_test is a smaller closure only building for a single system arch - qemu = pkgs.qemu_test; + qemu = pkgs.qemu; mkQemuFlags = extraFlags: [ "-enable-kvm" ```

This branch is already included in the target branch. There is nothing to merge.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u forceshutdownnow:astro-forceshutdownnow

git checkout astro-forceshutdownnow

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/wfvm#11