autounattend: use ForceShutdownNow instead of FirstLogonCommands shutdown #11

Open
astro wants to merge 1 commits from astro/wfvm:forceshutdownnow into master
astro commented 8 months ago
Collaborator

this moves the return a little earlier in the installation process.
it is less of a hack, and less problematic with custom defaultUser
settings.

this moves the return a little earlier in the installation process. it is less of a hack, and less problematic with custom `defaultUser` settings.
astro added 1 commit 8 months ago
54d9f41a6d autounattend: use ForceShutdownNow instead of FirstLogonCommands shutdown
Owner

@astro I don't feel qualified to comment on the technical side of things here. If this is tested and works, let's merge it.

@astro I don't feel qualified to comment on the technical side of things here. If this is tested and works, let's merge it.
Poster
Collaborator

As this patch shifts the OOBE pass to the next layer (DisablePasswordExpiry), that will run longer. I found it helpful to increase timeout on slower machines.

@parthy Care to test wfvm pull requests in your environment?

As this patch shifts the OOBE pass to the next layer (`DisablePasswordExpiry`), that will run longer. I found it helpful to increase [timeout](https://git.m-labs.hk/M-Labs/wfvm/src/commit/ec54c9bf9b55403c859f10cdeee9370f8d64e69e/wfvm/utils.nix#L34) on slower machines. @parthy Care to test wfvm pull requests in your environment?

Unfortunately, due to the change in ec54c9bf9b, our pipeline fails to run on this:

qemu-system-x86_64: QXL VGA not available

Unfortunately, due to the change in https://git.m-labs.hk/M-Labs/wfvm/commit/ec54c9bf9b55403c859f10cdeee9370f8d64e69e, our pipeline fails to run on this: `qemu-system-x86_64: QXL VGA not available`
Poster
Collaborator

qemu-system-x86_64: QXL VGA not available

Do you run qemu that is built w/o support for -vga qxl? That should be fixable.

> `qemu-system-x86_64: QXL VGA not available` Do you run qemu that is built w/o support for `-vga qxl`? That should be fixable.

I'm not running any custom qemu. I think the build process just picks pkgs.qemu, or not? Is it the fact that I am running the build in a pure server environment? (GitLab pipeline, Hydra)

I'm not running any custom qemu. I think the build process just picks `pkgs.qemu`, or not? Is it the fact that I am running the build in a pure server environment? (GitLab pipeline, Hydra)
Poster
Collaborator

@parthy The issue is that the build process contains qemu_test which seems to lack QXL by default now.

diff --git wfvm/utils.nix wfvm/utils.nix
index eb81579..e4927f7 100644
--- wfvm/utils.nix
+++ wfvm/utils.nix
@@ -2,7 +2,7 @@
 
 rec {
   # qemu_test is a smaller closure only building for a single system arch
-  qemu = pkgs.qemu_test;
+  qemu = pkgs.qemu;
 
   mkQemuFlags = extraFlags: [
     "-enable-kvm"
@parthy The issue is that the build process contains qemu_test which seems to lack QXL by default now. ```patch diff --git wfvm/utils.nix wfvm/utils.nix index eb81579..e4927f7 100644 --- wfvm/utils.nix +++ wfvm/utils.nix @@ -2,7 +2,7 @@ rec { # qemu_test is a smaller closure only building for a single system arch - qemu = pkgs.qemu_test; + qemu = pkgs.qemu; mkQemuFlags = extraFlags: [ "-enable-kvm" ```
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.