M-Labs/web2019
5
0
Fork 2
Code Issues 20 Pull Requests 3 Releases Wiki Activity

shop: remove animation from backlog #83

Merged
sb10q merged 7 commits from esavkin/web2019:79-animation-fix into master 2023-08-10 12:29:42 +08:00
Conversation 4 Commits 7 Files Changed 8 +84 -89
esavkin commented 2023-07-26 12:09:39 +08:00
Member
Copy Link
  • fixed bunch of warnings and type errors that appeared to be in the development version only
  • further fixed pl/pr -> ps/pe
  • fixed spacings at import json modal, closes #81
  • closes #72, removes reliance on unreliable user-agent in determining mobile devices
  • removed weird animations from backlog, closes #79
* fixed bunch of warnings and type errors that appeared to be in the development version only * further fixed pl/pr -> ps/pe * fixed spacings at `import json` modal, closes #81 * closes #72, removes reliance on unreliable user-agent in determining mobile devices * removed weird animations from backlog, closes #79
esavkin added 7 commits 2023-07-26 12:09:40 +08:00 
Signed-off-by: Egor Savkin <es@m-labs.hk>
Signed-off-by: Egor Savkin <es@m-labs.hk>
Signed-off-by: Egor Savkin <es@m-labs.hk>
Signed-off-by: Egor Savkin <es@m-labs.hk>
Signed-off-by: Egor Savkin <es@m-labs.hk>
Signed-off-by: Egor Savkin <es@m-labs.hk>
Signed-off-by: Egor Savkin <es@m-labs.hk>
esavkin changed title from shop: remove animation from backlog to WIP: shop: remove animation from backlog 2023-07-26 13:13:36 +08:00
esavkin commented 2023-07-26 13:16:52 +08:00
Author
Member
Copy Link

I'll test it with android emulator

I'll test it with android emulator
esavkin changed title from WIP: shop: remove animation from backlog to shop: remove animation from backlog 2023-07-26 15:05:32 +08:00
esavkin commented 2023-07-26 15:09:31 +08:00
Author
Member
Copy Link

Tested on GalaxyS23 and Pixel4XL, this patch doesn't break anything on FF and Samsung Internet (which is chromium), but the #84 was discovered

Tested on GalaxyS23 and Pixel4XL, this patch doesn't break anything on FF and Samsung Internet (which is chromium), but the #84 was discovered
sb10q commented 2023-08-10 12:28:33 +08:00
Owner
Copy Link

but the #84 was discovered

Which is not related to this PR, is it?

> but the #84 was discovered Which is not related to this PR, is it?
sb10q merged commit dee2a40151 into master 2023-08-10 12:29:42 +08:00
esavkin commented 2023-08-10 12:29:59 +08:00
Author
Member
Copy Link

but the #84 was discovered

Which is not related to this PR, is it?

It is present on the older version as well

> > but the #84 was discovered > > Which is not related to this PR, is it? It is present on the older version as well
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#83
No description provided.
Delete Branch "esavkin/web2019:79-animation-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?