M-Labs
/
web2019
5
0
Fork 2
Code Issues 20 Pull Requests 3 Releases Wiki Activity

Update node modules #77

Merged
sb10q merged 1 commits from esavkin/web2019:68-update-node-modules into master 2024-08-17 17:37:18 +08:00
Conversation 2 Commits 1 Files Changed 7 +6 -2200
esavkin commented 2023-07-12 15:36:12 +08:00
Member
Copy Link

Closes #68

Major changes:

  • Bootstrap 4.3.1 -> 5.3.0
  • React 16 -> 18
  • shop is webpack'ed with all dependencies now (except bootstrap which is loaded everywhere)

Visible changes:

  • Data blocks are wider on wide screens (more than 1400px width), which was previously limited by 1200px screens
  • Data blocks are slightly wider on not-that-wide screens
  • H1's are slightly smaller
  • <small> fonts are slightly bigger
  • on resources page, cards are now stretching to fit the content (all cards in row adjust to be same height), which is observable on tablets
  • shop categories are wrapped in proper accordions with arrows

No significant performance changes observed, however bootstrap 5 is thicker than bootstrap 4.3 for ~50% (mostly by CSS part), meanwhile the shop bundle has slightly decreased size (~10%) compared to the older shop+dependencies.

Closes #68 Major changes: * Bootstrap 4.3.1 -> 5.3.0 * React 16 -> 18 * shop is webpack'ed with all dependencies now (except bootstrap which is loaded everywhere) Visible changes: * Data blocks are wider on wide screens (more than 1400px width), which was previously limited by 1200px screens * Data blocks are slightly wider on not-that-wide screens * H1's are slightly smaller * `<small>` fonts are slightly bigger * on resources page, cards are now stretching to fit the content (all cards in row adjust to be same height), which is observable on tablets * shop categories are wrapped in proper accordions with arrows No significant performance changes observed, however bootstrap 5 is thicker than bootstrap 4.3 for ~50% (mostly by CSS part), meanwhile the shop bundle has slightly decreased size (~10%) compared to the older shop+dependencies.
esavkin added 9 commits 2023-07-12 15:36:14 +08:00
e5d754d2bc Just update dependencies, without any migration/bugfixing 
Signed-off-by: Egor Savkin <es@m-labs.hk>
85429b64f8 Add webpack 
Signed-off-by: Egor Savkin <es@m-labs.hk>
76dc20c798 Fix dropdown, accordion and modal 
Signed-off-by: Egor Savkin <es@m-labs.hk>
61d580fda4 Bring back source map for bootstrap stylesheet 
Signed-off-by: Egor Savkin <es@m-labs.hk>
ddd49b71af Fix solvespace 3d models display 
Signed-off-by: Egor Savkin <es@m-labs.hk>
053d31ddce Optimize webpack usage 
Signed-off-by: Egor Savkin <es@m-labs.hk>
sb10q commented 2023-07-12 16:04:59 +08:00
Owner
Copy Link

Visible changes:

Why?

IIRC the current design is pixel-accurate against some Photoshop renderings from the graphics designer. It should be possible to keep it that way.

> Visible changes: Why? IIRC the current design is pixel-accurate against some Photoshop renderings from the graphics designer. It should be possible to keep it that way.
esavkin commented 2023-07-12 16:23:15 +08:00
Author
Member
Copy Link

Why?

That's mostly due to the changes in bootstrap styles, which is not bad in my opinion, but it can be changed to make it the same as older design.

Also the cards are now stretching is actually a fix for tablets, which exists on current master.

And I forgot to mention that in the shop there are proper accordions instead of cards. So there are proper arrows now

> Why? That's mostly due to the changes in bootstrap styles, which is not bad in my opinion, but it can be changed to make it the same as older design. Also the `cards are now stretching` is actually a fix for tablets, which exists on current master. And I forgot to mention that in the shop there are proper accordions instead of cards. So there are proper arrows now
sb10q merged commit 053d31ddce into master 2023-07-14 09:01:04 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#77
No description provided.
Delete Branch "esavkin/web2019:68-update-node-modules"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?