M-Labs
/
web2019
5
0
Fork 2
Code Issues 20 Pull Requests 3 Releases Wiki Activity

Fixes text clearing in "Import JSON" #49

Merged
sb10q merged 1 commits from occheung/web2019:fix-text-clear into master 2021-06-02 09:07:13 +08:00
Conversation 1 Commits 1 Files Changed 2 +2 -10
occheung commented 2021-06-01 12:11:49 +08:00
Member
Copy Link

This PR is to fix #32.

  • The bypass logic on checkValidation() is removed. It prevents the text to be cleared.
  • The validation check on "load configuration handler" (i.e. handleClickLoad()) is performed on the content of the textbox.
This PR is to fix [#32](https://git.m-labs.hk/M-Labs/web2019/issues/32). * The [bypass logic](https://git.m-labs.hk/occheung/web2019/src/commit/61b291b9e0bf1afe58b2e6b5a4208cb74146370e/static/js/shop.jsx#L186-L188) on `checkValidation()` is removed. It prevents the text to be cleared. * The [validation check](https://git.m-labs.hk/occheung/web2019/src/commit/274935aed2fff1a34c91402baf1d5c279bb5c236/static/js/shop.jsx#L280) on "load configuration handler" (i.e. `handleClickLoad()`) is performed on the content of the textbox.
occheung force-pushed fix-text-clear from 274935aed2 to 8c3a35cea4 2021-06-01 17:05:29 +08:00 Compare
occheung commented 2021-06-01 17:11:34 +08:00
Author
Member
Copy Link

8c3a35cea4 reverts the unnecessary changes to shop.min.js, generated by building packages in different version.

8c3a35cea4 reverts the unnecessary changes to `shop.min.js`, generated by building packages in different version.
sb10q merged commit 8c3a35cea4 into master 2021-06-02 09:07:13 +08:00
occheung deleted branch fix-text-clear 2021-06-02 09:31:02 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#49
No description provided.
Delete Branch "occheung/web2019:fix-text-clear"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?