Fixes text clearing in "Import JSON" #49

Merged
sb10q merged 1 commits from occheung/web2019:fix-text-clear into master 5 months ago
Collaborator

This PR is to fix #32.

  • The bypass logic on checkValidation() is removed. It prevents the text to be cleared.
  • The validation check on "load configuration handler" (i.e. handleClickLoad()) is performed on the content of the textbox.
This PR is to fix [#32](https://git.m-labs.hk/M-Labs/web2019/issues/32). * The [bypass logic](https://git.m-labs.hk/occheung/web2019/src/commit/61b291b9e0bf1afe58b2e6b5a4208cb74146370e/static/js/shop.jsx#L186-L188) on `checkValidation()` is removed. It prevents the text to be cleared. * The [validation check](https://git.m-labs.hk/occheung/web2019/src/commit/274935aed2fff1a34c91402baf1d5c279bb5c236/static/js/shop.jsx#L280) on "load configuration handler" (i.e. `handleClickLoad()`) is performed on the content of the textbox.
occheung added 1 commit 5 months ago
occheung force-pushed fix-text-clear from 274935aed2 to 8c3a35cea4 5 months ago
Poster
Collaborator

8c3a35cea4 reverts the unnecessary changes to shop.min.js, generated by building packages in different version.

8c3a35cea4 reverts the unnecessary changes to `shop.min.js`, generated by building packages in different version.
sb10q merged commit 8c3a35cea4 into master 5 months ago
occheung deleted branch fix-text-clear 5 months ago
The pull request has been merged as 8c3a35cea4.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.