Replace download button with dropdown #158

Merged

sb10q merged 3 commits from esavkin/web2019:154-dropdown-download into master 2024-10-21 17:50:21 +08:00

Conversation 6 Commits 3 Files Changed 3 +120 -44

esavkin commented 2024-10-18 12:33:21 +08:00

Member

Copy Link

Closes #154

Closes #154 

Screenshot from 2024-10-21 15-31-54.png

12 KiB

esavkin added 1 commit 2024-10-18 12:33:22 +08:00

92f7428ac8 Replace download button with dropdown ...

Signed-off-by: Egor Savkin <es@m-labs.hk>

sb10q commented 2024-10-18 13:47:19 +08:00

Owner

Copy Link

Just clicking on the button should download stable. The appearance and functionality should be similar to this button:

Just clicking on the button should download stable. The appearance and functionality should be similar to this button: 

image.png

3.5 KiB

esavkin added 1 commit 2024-10-21 15:32:24 +08:00

9d9a4c9f5a Split dropdown ...

On main click it downloads stable, in dropdown there are two choices - stable and beta. Similar to the downloads on jetbrains website

Signed-off-by: Egor Savkin <es@m-labs.hk>

sb10q commented 2024-10-21 15:34:23 +08:00

Owner

Copy Link

Doesn't look good. Pay close attention to the model.

Doesn't look good. Pay close attention to the model.

esavkin commented 2024-10-21 15:54:06 +08:00

Author

Member

Copy Link

Which model?

I don't think the gitea's merge button is suitable for downloads, as they have different effect. In gitea, the user chooses action first and then confirms it, because reverting it may be difficult.

Here the user just wants to download installer without additional clicks, and it was inspired from download button from the Jetbrains, since their purpose is the same and I'm pretty sure they've done proper UX research about it. Main button downloads the default option, and the dropdown contains all variants, and by clicking any the download starts shortly.

Which model? I don't think the gitea's merge button is suitable for downloads, as they have different effect. In gitea, the user chooses action first and then confirms it, because reverting it may be difficult. Here the user just wants to download installer without additional clicks, and it was inspired from download button from the Jetbrains, since their purpose is the same and I'm pretty sure they've done proper UX research about it. Main button downloads the default option, and the dropdown contains all variants, and by clicking any the download starts shortly. 

image.png

10 KiB

sb10q commented 2024-10-21 15:58:34 +08:00

Owner

Copy Link

Hmm, valid points, but the button just becomes gigantic, which is why I was thinking of removing the "stable".

Just reduce the font sizes and/or margins perhaps?

Hmm, valid points, but the button just becomes gigantic, which is why I was thinking of removing the "stable".  Just reduce the font sizes and/or margins perhaps?

image.png

12 KiB

esavkin added 1 commit 2024-10-21 17:46:47 +08:00

f29807a913 Optimize the download button ...

Replace download button with windows icon (just four squares).
Make the download button last so on certain screens it wouldn't cause additional empty-ish lines.
Redo the wording so the button is shorter, but the dropdown menu is filled.

Signed-off-by: Egor Savkin <es@m-labs.hk>

esavkin commented 2024-10-21 17:47:48 +08:00

Author

Member

Copy Link

How about such design?

How about such design? 

image.png

21 KiB

sb10q commented 2024-10-21 17:48:20 +08:00

Owner

Copy Link

OK

OK

sb10q merged commit f29807a913 into master 2024-10-21 17:50:21 +08:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#158

No description provided.