Add warnings if phaser has next card too long and increase it's virtual HP consumption #151

esavkin · 2024-09-05T12:29:19+08:00

esavkin commented

2024-09-05 12:29:19 +08:00

Closes #148

esavkin added 2 commits 2024-09-05 12:29:20 +08:00

Add warnings for the phaser being obstacled by next card c1e26e7ba8

Update bundle and remove debug messages from production build cc89d0b1fd

Signed-off-by: Egor Savkin <es@m-labs.hk>

esavkin force-pushed 148-phaser-fix from cc89d0b1fd to 2868c8d4cd

2024-10-14 11:06:46 +08:00

Compare

sb10q reviewed 2024-10-16 11:22:42 +08:00

static/js/shop/warnings.js

						
				@ -145,1 +158,4 @@

				        }

				    },

				    "phaser_not_fit": {

				        message: "Since one or more Phasers may interfere with their next cards, they may additional space, that wouldn't fit into the crate. Consider removing cards, placing short cards after Phaser(s), or choosing larger crate.",

sb10q commented

2024-10-16 11:22:42 +08:00

"they may additional space"?

sb10q commented

2024-10-16 11:23:14 +08:00

And why "may interfere"? It's pretty clear whether they do or not.

And why "*may* interfere"? It's pretty clear whether they do or not.

This pull request has changes conflicting with the target branch.

static/js/shop.bundle.js

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 148-phaser-fix:esavkin-148-phaser-fix

git checkout esavkin-148-phaser-fix

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#151