M-Labs
/
web2019
5
0
Fork 2
Code Issues 20 Pull Requests 3 Releases Wiki Activity

Update dependencies,some clean up and small fixes #147

Merged
sb10q merged 1 commits from esavkin/web2019:125-bug-fixes into master 2024-08-17 17:37:19 +08:00
Conversation 0 Commits 1 Files Changed 3 +1026 -1105
esavkin commented 2024-08-05 11:35:56 +08:00
Member
Copy Link
  • update and clean up NPM dependencies
  • Move out subcomponents of ProductItem for maintainability
  • Make tooltip icons inline so they form a new line more rarely
  • Fix options pop up being styled as both first and last (only getting reproduced in spare cards, which is impossible at the moment, but upcoming feature)
  • remove type field from shop_data as it was not used in the code

4 of these commits update the bundle, so I don't think it is necessary to split this PR into smaller ones.

* update and clean up NPM dependencies * Move out subcomponents of ProductItem for maintainability * Make tooltip icons inline so they form a new line more rarely * Fix options pop up being styled as both first and last (only getting reproduced in spare cards, which is impossible at the moment, but upcoming feature) * remove `type` field from shop_data as it was not used in the code 4 of these commits update the bundle, so I don't think it is necessary to split this PR into smaller ones.
esavkin added 5 commits 2024-08-05 11:35:56 +08:00
b0ef9d07fc Remove unused type field from shop_data 
Signed-off-by: Egor Savkin <es@m-labs.hk>
68677dce6e Make tooltip icons inline 
Signed-off-by: Egor Savkin <es@m-labs.hk>
c7b0d5568c Fix options pop up being both first and last 
Signed-off-by: Egor Savkin <es@m-labs.hk>
52c05c2e2a Move out subcomponents of ProductItem 
This improves maintenance as it reduces complexity of the ProductItem component and allows seeing components in react dev tools

Signed-off-by: Egor Savkin <es@m-labs.hk>
b53e191528 Update and clean up NPM dependencies 
npm audit also reported 0 vulnerabilities

Signed-off-by: Egor Savkin <es@m-labs.hk>
sb10q merged commit b53e191528 into master 2024-08-05 18:53:05 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#147
No description provided.
Delete Branch "esavkin/web2019:125-bug-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?