M-Labs/web2019
5
0
Fork 2
Code Issues 20 Pull Requests 3 Releases Wiki Activity

shop: add crateless items and options #143

Open
esavkin wants to merge 7 commits from esavkin/web2019:125-crateless into master
pull from: esavkin/web2019:125-crateless
merge into: M-Labs:master
Conversation 8 Commits 7 Files Changed 22 +646 -219
esavkin commented 2024-07-19 16:46:16 +08:00
Member
Copy Link

Closes #125

  • add crateless options feature - these options are available when the card/item is added to "Spare items"
  • add crateless options for stabilizer, pounder, fast-servo, thermostat and thermostat-eem
  • add crateless items feature - cards with crateless: true field will automatically go to "Spare items", and "Spare items" will be opened if closed
  • add horizontal items, that are getting inserted into vertical list in the Spare items, under cards. This type of items can be used for all other items that we sell, for example AFWS.
  • add AFWS item as an example of crateless items. The icon design was decided to be mostly the same, but not having screws
  • various bugfixes discovered after implementation of above features #147
Closes #125 * add crateless options feature - these options are available when the card/item is added to "Spare items" * add crateless options for stabilizer, pounder, fast-servo, thermostat and thermostat-eem * add crateless items feature - cards with `crateless: true` field will automatically go to "Spare items", and "Spare items" will be opened if closed * add horizontal items, that are getting inserted into vertical list in the Spare items, under cards. This type of items can be used for all other items that we sell, for example AFWS. * ~~add AFWS item as an example of crateless items. The icon design was decided to be mostly the same, but not having screws~~ * ~~various bugfixes discovered after implementation of above features~~ https://git.m-labs.hk/M-Labs/web2019/pulls/147
sb10q commented 2024-07-19 17:28:43 +08:00
Owner
Copy Link

various bugfixes discovered after implementation of above features

Can you remember what I told you at least 25 times about how PRs need to be organized?

> various bugfixes discovered after implementation of above features Can you remember what I told you at least 25 times about how PRs need to be organized?
esavkin commented 2024-07-19 17:37:24 +08:00
Author
Member
Copy Link

Can you remember what I told you at least 25 times about how PRs need to be organized?

Yes, I remember, however these bug fixes are not really relevant without crateless options and items.

> Can you remember what I told you at least 25 times about how PRs need to be organized? Yes, I remember, however these bug fixes are not really relevant without crateless options and items.
esavkin commented 2024-08-05 11:40:04 +08:00
Author
Member
Copy Link

Depends (and conflicts) on #147

Depends (and conflicts) on https://git.m-labs.hk/M-Labs/web2019/pulls/147
sb10q commented 2024-08-05 11:41:46 +08:00
Owner
Copy Link

Wouldn't spend too much time on this one for now. Eventually we should probably refactor the shop into some kind of McMasterCarr design with more general items for sale, instead of trying to shoehorn all kinds of features into the crate interface.

Wouldn't spend too much time on this one for now. Eventually we should probably refactor the shop into some kind of McMasterCarr design with more general items for sale, instead of trying to shoehorn all kinds of features into the crate interface.
esavkin force-pushed 125-crateless from 4437b86f68 to 5c449d9502 2024-08-06 11:09:12 +08:00 Compare
esavkin commented 2024-08-06 11:24:42 +08:00
Author
Member
Copy Link

some kind of McMasterCarr design with more general items for sale, instead of trying to shoehorn all kinds of features into the crate interface.

Well, McMasterCarr design is quite outdated and not that easy to use (IMHO) and I don't see that they have assembly options. Wouldn't we need crates assembly functionality, anything like Rakuten/Mercari/TaoBao/Amazon/Ozon/That-default-shop-design would be enough.

There better be some proper UX research/experiments before doing it, at least asking a fair amount of diverse people their opinion on different designs.

> some kind of McMasterCarr design with more general items for sale, instead of trying to shoehorn all kinds of features into the crate interface. Well, McMasterCarr design is quite outdated and not that easy to use (IMHO) and I don't see that they have assembly options. Wouldn't we need crates assembly functionality, anything like Rakuten/Mercari/TaoBao/Amazon/Ozon/That-default-shop-design would be enough. There better be some proper UX research/experiments before doing it, at least asking a fair amount of _diverse_ people their opinion on different designs.
sb10q commented 2024-08-06 11:29:13 +08:00
Owner
Copy Link

The McMaster Carr web design is excellent and if you do 5 min of search you will find that a lot of people are in agreement, along with arguments as to why.
I'm not proposing replacing the entire crate system with a traditional web shop - that would be obviously stupid, the current crate system is very good and should stay - but complementing/integrating it with one.

The McMaster Carr web design is excellent and if you do 5 min of search you will find that a lot of people are in agreement, along with arguments as to why. I'm not proposing replacing the entire crate system with a traditional web shop - that would be obviously stupid, the current crate system is very good and should stay - but complementing/integrating it with one.
esavkin commented 2024-08-06 12:15:24 +08:00
Author
Member
Copy Link

The McMaster Carr web design is excellent

It may be nearly perfect for their use-case (huge catalog of similar but different items) https://patents.google.com/patent/US9870582B2/ , but I really doubt most of it would be applicable to the small set of highly customizable items.

The only thing I can see being slightly useful is the filtering/search functionality (if we can avoid the patent), but more than 1 layer of grouping is an overkill for now.

> The McMaster Carr web design is excellent It may be nearly perfect for their use-case (huge catalog of similar but different items) https://patents.google.com/patent/US9870582B2/ , but I really doubt most of it would be applicable to the small set of highly customizable items. The only thing I can see being slightly useful is the filtering/search functionality (if we can avoid the patent), but more than 1 layer of grouping is an overkill for now.
esavkin force-pushed 125-crateless from 5c449d9502 to 5e5246e8ae 2024-10-14 11:08:33 +08:00 Compare
sb10q commented 2024-10-16 11:21:34 +08:00
Owner
Copy Link

add AFWS item as an example of crateless items.

Making it look like a card is pretty bad. Please remove it entirely from this PR for now and let's see later how/if it could be added to the online store.

> add AFWS item as an example of crateless items. Making it look like a card is pretty bad. Please remove it entirely from this PR for now and let's see later how/if it could be added to the online store.
esavkin changed title from shop: add crateless items and options to WIP: shop: add crateless items and options 2024-10-31 16:02:14 +08:00
esavkin force-pushed 125-crateless from 5e5246e8ae to 608f253684 2024-11-01 17:33:07 +08:00 Compare
esavkin force-pushed 125-crateless from 608f253684 to 7a2e8e8f7d 2024-11-04 17:42:24 +08:00 Compare
esavkin force-pushed 125-crateless from 7a2e8e8f7d to 3dc1cbc6a2 2024-11-05 17:44:00 +08:00 Compare
esavkin force-pushed 125-crateless from 3dc1cbc6a2 to aecfce8718 2024-11-06 16:47:35 +08:00 Compare
esavkin force-pushed 125-crateless from aecfce8718 to 35d9ab3729 2024-11-06 16:56:00 +08:00 Compare
esavkin force-pushed 125-crateless from 35d9ab3729 to 84562f276a 2024-11-06 17:18:30 +08:00 Compare
esavkin changed title from WIP: shop: add crateless items and options to shop: add crateless items and options 2024-11-06 17:29:22 +08:00
This pull request has changes conflicting with the target branch.
  • static/js/shop.bundle.js
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 125-crateless:esavkin-125-crateless
git checkout esavkin-125-crateless
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#143
No description provided.
Delete Branch "esavkin/web2019:125-crateless"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?