M-Labs
/
web2019
5
0
Fork 2
Code Issues 18 Pull Requests Releases Wiki Activity

Order and crate level options #117

Merged
sb10q merged 7 commits from esavkin/web2019:64-nuc-checkbox into master 2024-02-15 12:32:44 +08:00
Conversation 4 Commits 7 Files Changed 37
esavkin commented 2024-02-01 12:43:04 +08:00
Collaborator

Closes #114
Closes #64
Also reimplements #78, so everything is generic and controlled from shop_data.js

Closes #114 Closes #64 Also reimplements #78, so everything is generic and controlled from shop_data.js
esavkin added 5 commits 2024-02-01 12:43:05 +08:00
8f334120cd Prototype crate and order options 
Signed-off-by: Egor Savkin <es@m-labs.hk>
20319b6500 Add flexible crate options 
Signed-off-by: Egor Savkin <es@m-labs.hk>
6b27ac49b5 Cache total price calculation 
Signed-off-by: Egor Savkin <es@m-labs.hk>
b145b8d9ad Add order options 
Signed-off-by: Egor Savkin <es@m-labs.hk>
feb43eb1d1 Add more order options and enhance the look of them 
Signed-off-by: Egor Savkin <es@m-labs.hk>
sb10q commented 2024-02-01 20:33:04 +08:00
Owner
  • Move shipping options below price estimate to keep it visible
  • Put Gnome/KDE on the same line as "Desktop Environment" to save vertical space
  • Change "opt out" to "include" promotional USB stick
  • Make promotional USB stick option visible at all times, even with NUC selected
  • Clarify that ARTIQ also gets installed on the NUC
  • With Firefox, the tooltips of the NUC options sometimes flash at the left of the page. The issue is also present with the fan tray option. A horizontal scrollbar also flashes sometimes with those tooltips.
* Move shipping options below price estimate to keep it visible * Put Gnome/KDE on the same line as "Desktop Environment" to save vertical space * Change "opt out" to "include" promotional USB stick * Make promotional USB stick option visible at all times, even with NUC selected * Clarify that ARTIQ also gets installed on the NUC * With Firefox, the tooltips of the NUC options sometimes flash at the left of the page. The issue is also present with the fan tray option. A horizontal scrollbar also flashes sometimes with those tooltips.
esavkin added 1 commit 2024-02-02 17:24:10 +08:00
esavkin commented 2024-02-02 17:36:49 +08:00
Poster
Collaborator

With Firefox, the tooltips of the NUC options sometimes flash at the left of the page. The issue is also present with the fan tray option. A horizontal scrollbar also flashes sometimes with those tooltips.

https://github.com/react-bootstrap/react-bootstrap/issues/6563

> With Firefox, the tooltips of the NUC options sometimes flash at the left of the page. The issue is also present with the fan tray option. A horizontal scrollbar also flashes sometimes with those tooltips. https://github.com/react-bootstrap/react-bootstrap/issues/6563
sb10q commented 2024-02-07 15:01:23 +08:00
Owner

https://github.com/react-bootstrap/react-bootstrap/issues/6563

Okay but this affects us and gives the website an amateur feel. Is it hard to fix or work around?

"configuration files" should be changed to "device database and other relevant files" to put accent on the most important one. Also, when we have an offline installer, we'll probably want it on the USB stick and it's not a configuration file.

> https://github.com/react-bootstrap/react-bootstrap/issues/6563 Okay but this affects us and gives the website an amateur feel. Is it hard to fix or work around? "configuration files" should be changed to "device database and other relevant files" to put accent on the most important one. Also, when we have an offline installer, we'll probably want it on the USB stick and it's not a configuration file.
👍 1
sb10q commented 2024-02-07 15:03:37 +08:00
Owner

Also remove the comparison between KDE/Gnome, the difference is more complex and somewhat subjective and this web page isn't the place to discuss it.

Also remove the comparison between KDE/Gnome, the difference is more complex and somewhat subjective and this web page isn't the place to discuss it.
👍 1
esavkin added 1 commit 2024-02-07 16:23:33 +08:00
esavkin force-pushed 64-nuc-checkbox from 9195feb42e to 67cef120b6 2024-02-15 12:20:32 +08:00 Compare
sb10q merged commit 67cef120b6 into master 2024-02-15 12:32:44 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#117
There is no content yet.
Delete Branch "esavkin/web2019:64-nuc-checkbox"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?