M-Labs
/
web2019
5
0
Fork 2
Code Issues 18 Pull Requests Releases Wiki Activity

Refactor shop.jsx #96

New Issue
Closed
opened 2023-09-29 12:34:57 +08:00 by esavkin · 1 comment
esavkin commented 2023-09-29 12:34:57 +08:00
Collaborator

Since the integration of webpack, there is no real reason to keep all the code in single file. Components may be split between files, to make them easier to navigate and reuse. Overall maintainability should increase after reorganization of components.
Also upcoming shop options may be reorganized as well.

Since the integration of webpack, there is no real reason to keep all the code in single file. Components may be split between files, to make them easier to navigate and reuse. Overall maintainability should increase after reorganization of components. Also upcoming shop options may be reorganized as well.
esavkin commented 2023-11-21 10:01:57 +08:00
Poster
Collaborator

Refactor checkAlerts() function (and warnings system, to fix the #108) to make it more generic and flexible, so various warnings can be added at any time. For now it is >300 lines of hot mess.

Refactor `checkAlerts()` function (and warnings system, to fix the #108) to make it more generic and flexible, so various warnings can be added at any time. For now it is >300 lines of hot mess.
sb10q closed this issue 2024-01-23 16:48:54 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#96
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?