M-Labs
/
web2019
5
0
Fork 2
Code Issues 18 Pull Requests Releases Wiki Activity

shop: add Pounder #87

Merged
sb10q merged 2 commits from esavkin/web2019:42-pounder into master 2023-08-10 12:27:06 +08:00
Conversation 0 Commits 2 Files Changed 4
esavkin commented 2023-08-07 15:26:23 +08:00
Collaborator

Closes #42

Closes #42
pounder_stabilizer.svg
87 KiB
pounder_stabilizer.svg
esavkin added 2 commits 2023-08-07 15:26:24 +08:00
2ab248ea92 Merge pictures of Pounder with Stabilizer 
Signed-off-by: Egor Savkin <es@m-labs.hk>
sb10q reviewed 2023-08-07 15:44:42 +08:00
static/js/shop_data.js Outdated
@ -870,0 +877,4 @@
image: '/shop/graphic-03_Pounder.svg',
specs: [
'2-channel Pound Drever Hall (PDH) lock generator.',
'This is a daughter card that stacks on top of the Stabilizer.',
sb10q commented 2023-08-07 15:44:42 +08:00
Owner

Stabilizer is included in the price. This makes it sound like it isn't.

Stabilizer is included in the price. This makes it sound like it isn't.
sb10q commented 2023-08-07 15:45:48 +08:00
Owner

Follow Almazny e.g. "Stabilizer with Pounder daughter card..."

Follow Almazny e.g. "Stabilizer with Pounder daughter card..."
👍 1
sb10q reviewed 2023-08-07 15:46:38 +08:00
static/js/shop_data.js
@ -913,6 +934,7 @@ const shop_data = {
itemIds: [
'koster',
'stabilizer',
'pounder',
sb10q commented 2023-08-07 15:46:38 +08:00
Owner

Arguably a RF card.

Arguably a RF card.
sb10q commented 2023-08-07 15:47:11 +08:00
Owner

Can it be listed in both places?

Can it be listed in both places?
esavkin commented 2023-08-07 16:42:24 +08:00
Poster
Collaborator

Yes, but requires some refactoring

Yes, but requires some refactoring
esavkin commented 2023-08-10 12:06:00 +08:00
Poster
Collaborator

Should I do it?

Should I do it?
sb10q commented 2023-08-10 12:26:43 +08:00
Owner

Yes

Yes
esavkin force-pushed 42-pounder from 2ab248ea92 to 15187ebaf2 2023-08-07 16:47:39 +08:00 Compare
sb10q merged commit b3964ec2c9 into master 2023-08-10 12:27:06 +08:00
sb10q referenced this issue from a commit 2023-08-10 12:27:07 +08:00
shop: add Pounder (#87)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#87
There is no content yet.
Delete Branch "esavkin/web2019:42-pounder"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?