shop: update design for foldables and tablets #72

New Issue

esavkin · 2023-07-05T17:28:12+08:00

esavkin commented

2023-07-05 17:28:12 +08:00

Probably deviceIsMobile needs to be fixed and rely more on screen size, rather than on which browser is used. It creates such silly situations when the side-menu buttons are rendered while CSS styles do not allow opening/closing it.

Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen.

Probably `deviceIsMobile` needs to be fixed and rely more on screen size, rather than on which browser is used. It creates such silly situations when the side-menu buttons are rendered while CSS styles do not allow opening/closing it. ![image](/attachments/23667a76-c01b-4f24-8da0-21ddf599258f) Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen. ![image](/attachments/3b1465be-9085-4e8a-b3fe-368a4f9cb067)

image.png

94 KiB

image.png

45 KiB

sb10q commented

2023-07-05 17:31:47 +08:00

Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen.

I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days.

> Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen. I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days.

esavkin commented

2023-07-05 17:37:04 +08:00

I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days.

The thing is that I actually don't know how it renders on real Fold, since it is said that this screen is far wider than 280px, but browser simulations only have such Fold. So it just needs checking.

I found this on gsmarena: 720 x 1680 pixels, 21:9 ratio

> I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days. The thing is that I actually don't know how it renders on real Fold, since it is said that this screen is far wider than 280px, but browser simulations only have such Fold. So it just needs checking. I found this on gsmarena: 720 x 1680 pixels, 21:9 ratio

esavkin referenced a pull request that will close this issue

2023-07-26 12:09:39 +08:00

shop: remove animation from backlog #83

sb10q referenced this issue from a commit

2023-08-10 12:29:42 +08:00

Fix #72 - make side-panel button depend on screen size, same as the appearance

sb10q closed this issue

2023-08-10 12:29:42 +08:00

Sign in to join this conversation.