M-Labs
/
web2019
5
0
Fork 2
Code Issues 18 Pull Requests Releases Wiki Activity

shop: update design for foldables and tablets #72

New Issue
Closed
opened 2023-07-05 17:28:12 +08:00 by esavkin · 2 comments
esavkin commented 2023-07-05 17:28:12 +08:00
Collaborator

Probably deviceIsMobile needs to be fixed and rely more on screen size, rather than on which browser is used. It creates such silly situations when the side-menu buttons are rendered while CSS styles do not allow opening/closing it.
image

Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen.
image

Probably `deviceIsMobile` needs to be fixed and rely more on screen size, rather than on which browser is used. It creates such silly situations when the side-menu buttons are rendered while CSS styles do not allow opening/closing it. ![image](/attachments/23667a76-c01b-4f24-8da0-21ddf599258f) Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen. ![image](/attachments/3b1465be-9085-4e8a-b3fe-368a4f9cb067)
image.png
94 KiB
image.png
45 KiB
sb10q commented 2023-07-05 17:31:47 +08:00
Owner

Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen.

I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days.

> Also Galaxy Fold needs checking as browser simulation shows the shop to be completely broken on smaller screen. I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days.
esavkin commented 2023-07-05 17:37:04 +08:00
Poster
Collaborator

I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days.

The thing is that I actually don't know how it renders on real Fold, since it is said that this screen is far wider than 280px, but browser simulations only have such Fold. So it just needs checking.

I found this on gsmarena: 720 x 1680 pixels, 21:9 ratio

> I don't think supporting devices with 280px screen resolution is worth our time. Most phones are 1080p or more these days. The thing is that I actually don't know how it renders on real Fold, since it is said that this screen is far wider than 280px, but browser simulations only have such Fold. So it just needs checking. I found this on gsmarena: 720 x 1680 pixels, 21:9 ratio
sb10q closed this issue 2023-08-10 12:29:42 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#72
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?