M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

Remove VREF in reports #85

Merged
sb10q merged 1 commits from atse/thermostat:remove-vref-reporting into master 2023-08-22 16:00:40 +08:00
Conversation 0 Commits 1 Files Changed 2 -8
atse commented 2023-08-22 11:46:12 +08:00
Contributor
Copy Link

Since VREF is an implementation detail, there shouldn't be a need to include it in reports.

The ChannelState vref is removed along with it as its only use was to save VREF measurements for later reporting.

Since VREF is an implementation detail, there shouldn't be a need to include it in reports. The ChannelState vref is removed along with it as its only use was to save VREF measurements for later reporting.
atse added 1 commit 2023-08-22 11:46:16 +08:00 
Since VREF is an implementation detail, there shouldn't be a need to
include it in reports.

The ChannelState vref is removed along with it as its only use was to
save VREF measurements for later reporting.
sb10q merged commit 9df0fe406f into master 2023-08-22 16:00:40 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#85
No description provided.
Delete Branch "atse/thermostat:remove-vref-reporting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?