M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

README: Correct unit of time in reports #77

Merged
sb10q merged 1 commits from atse/thermostat:fix-unit into master 2023-07-20 18:11:41 +08:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
atse commented 2023-07-20 17:52:07 +08:00
Contributor
Copy Link

Thermostat firmware reports time as seconds, not milliseconds. Fix documentation to match.

Evidence

Shortly after powering on thermostat and connecting with rlwrap nc -vv 192.168.1.26 23:

report
[{"channel":0,"time":6.154e0,"interval":1.2e-1,"adc":8.010958263703687e-1,"sens":9.625559259581125e3,"temperature":2.589543103629103e1,"pid_engaged":false,"i_set":4.034332406358754e-3,"vref":1.487e0,"dac_value":1.5000171662031794e0,"dac_feedback":1.496e0,"i_tec":1.5050000000000001e0,"tec_i":2.5000000000000022e-2,"tec_u_meas":-8.000000000000007e-3,"pid_output":0e0},{"channel":1,"time":6.214e0,"interval":1.2e-1,"adc":null,"sens":null,"temperature":null,"pid_engaged":false,"i_set":1.4900400544740848e0,"vref":1.499e0,"dac_value":2.2500200272370425e0,"dac_feedback":2.254e0,"i_tec":1.512e0,"tec_i":2.7499999999999747e-2,"tec_u_meas":-1.1999999999999567e-2,"pid_output":0e0}]
Thermostat firmware reports time as seconds, not milliseconds. Fix documentation to match. ## Evidence Shortly after powering on thermostat and connecting with `rlwrap nc -vv 192.168.1.26 23`: ``` report [{"channel":0,"time":6.154e0,"interval":1.2e-1,"adc":8.010958263703687e-1,"sens":9.625559259581125e3,"temperature":2.589543103629103e1,"pid_engaged":false,"i_set":4.034332406358754e-3,"vref":1.487e0,"dac_value":1.5000171662031794e0,"dac_feedback":1.496e0,"i_tec":1.5050000000000001e0,"tec_i":2.5000000000000022e-2,"tec_u_meas":-8.000000000000007e-3,"pid_output":0e0},{"channel":1,"time":6.214e0,"interval":1.2e-1,"adc":null,"sens":null,"temperature":null,"pid_engaged":false,"i_set":1.4900400544740848e0,"vref":1.499e0,"dac_value":2.2500200272370425e0,"dac_feedback":2.254e0,"i_tec":1.512e0,"tec_i":2.7499999999999747e-2,"tec_u_meas":-1.1999999999999567e-2,"pid_output":0e0}] ```
atse added 1 commit 2023-07-20 17:52:08 +08:00
sb10q merged commit cd680dd6cd into master 2023-07-20 18:11:41 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#77
No description provided.
Delete Branch "atse/thermostat:fix-unit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?