M-Labs
/
thermostat
9
0
Fork 5
Code Issues 10 Pull Requests 7 Releases Wiki Activity

Support fan PWM settings #73

Merged
sb10q merged 16 commits from esavkin/thermostat:69-fan_pwm into master 2023-03-22 17:15:49 +08:00
Conversation 9 Commits 16 Files Changed 8 +9 -1
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 83d5c28a67 - Show all commits

10
src/fan_ctrl.rs
View File

@ -54,7 +54,9 @@ impl FanCtrl {
FanCtrl { FanCtrl {
fan, fan,
available, available,
fan_auto: true, // do not enable auto mode by default,
// but allow to turn it on on customer's own risk
sb10q commented 2023-02-08 19:36:17 +08:00
Outdated
Review
Copy Link

at user's own risk

at user's own risk
fan_auto: hwrev.fan_auto_mode_available(),
k_a: DEFAULT_K_A, k_a: DEFAULT_K_A,
k_b: DEFAULT_K_B, k_b: DEFAULT_K_B,
k_c: DEFAULT_K_C, k_c: DEFAULT_K_C,
@ -142,6 +144,12 @@ impl HWRev {
pub fn fan_available(&self) -> bool { pub fn fan_available(&self) -> bool {
self.major == 2 && self.minor == 2 self.major == 2 && self.minor == 2
} }
pub fn fan_auto_mode_available(&self) -> bool {
sb10q commented 2023-02-08 19:37:16 +08:00
Outdated
Review
Copy Link

This poorly chosen name suggests that auto mode is not available at all.

Rename to fan_default_auto or similar.

This poorly chosen name suggests that auto mode is not available at all. Rename to fan_default_auto or similar.
// see https://github.com/sinara-hw/Thermostat/issues/115 and
// https://git.m-labs.hk/M-Labs/thermostat/issues/69#issuecomment-6464 for explanation
self.fan_available() && self.minor != 2
}
} }
#[derive(Serialize)] #[derive(Serialize)]