M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

Support fan PWM settings #73

Merged
sb10q merged 16 commits from esavkin/thermostat:69-fan_pwm into master 2023-03-22 17:15:49 +08:00
Conversation 9 Commits 16 Files Changed 8 +5 -7
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 069e178966 - Show all commits

4
src/fan_ctrl.rs
View File

@ -18,8 +18,8 @@ const MAX_TEC_I: f64 = 3.0;
const MAX_USER_FAN_PWM: f64 = 100.0;
const MIN_USER_FAN_PWM: f64 = 1.0;
const MAX_FAN_PWM: f64 = 1.0;
sb10q commented 2023-01-06 07:37:41 +08:00
Outdated
Review
Copy Link

"weak" suggests amplitude, which is incorrect.
-> "frequency is too low"

"weak" suggests amplitude, which is incorrect. -> "frequency is too low"
esavkin commented 2023-01-06 09:52:35 +08:00
Outdated
Review
Copy Link

no, not the frequency. The near-zero freq is the consequence of weak signal.

no, not the frequency. The near-zero freq is the consequence of weak signal.
sb10q commented 2023-01-06 10:07:02 +08:00
Outdated
Review
Copy Link

Do you have an oscilloscope picture demonstrating this, and how was it measured?

Do you have an oscilloscope picture demonstrating this, and how was it measured?
esavkin commented 2023-01-06 10:17:35 +08:00
Outdated
Review
Copy Link

We used pulse counter to measure the tacho values, for PWM 0.04-1.0 it was ok, but for lower the tacho signal disappears

We used pulse counter to measure the tacho values, for PWM 0.04-1.0 it was ok, but for lower the tacho signal disappears
// below this value motor circuit assumes there is no signal and runs full speed
const MIN_FAN_PWM: f64 = 0.02;
// below this value motor's autostart feature may fail
sb10q commented 2023-03-15 13:12:36 +08:00
Outdated
Review
Copy Link

According to ?

According to ?
esavkin commented 2023-03-15 13:20:57 +08:00
Outdated
Review
Copy Link

Internal experiments

Internal experiments
sb10q commented 2023-03-15 13:23:38 +08:00
Outdated
Review
Copy Link

Please say so in the code comments.

Please say so in the code comments.
👍 1
sb10q commented 2023-03-15 13:24:15 +08:00
Outdated
Review
Copy Link

Also we can probably expect this to be hardware revision dependent. When the fan has proper PWM support this shouldn't be an issue I guess.

Also we can probably expect this to be hardware revision dependent. When the fan has proper PWM support this shouldn't be an issue I guess.
👍 1
esavkin commented 2023-03-22 13:03:21 +08:00
Outdated
Review
Copy Link

Made this (and others) value coming from hwrev

Made this (and others) value coming from hwrev
const MIN_FAN_PWM: f64 = 0.04;
const DEFAULT_K_A: f64 = 1.0;
const DEFAULT_K_B: f64 = 0.0;

8
src/pins.rs
View File

@ -226,11 +226,9 @@ impl Pins {
hclk: clocks.hclk(),
};
// Though there is not enough evidence available for concrete fan model,
// it is generally advised to have higher PWM frequencies for brushless motors,
// so that it would produce less audible noise.
// Source: https://www.controleng.com/articles/understanding-the-effect-of-pwm-when-controlling-a-brushless-dc-motor/
let fan = Timer::new(tim8, &clocks).pwm(gpioc.pc9.into_alternate(), 80u32.khz());
// According to `SUNON DC Brushless Fan & Blower(255-E)` catalogue p.36-37
// Model name: MF35101V1-1000U-G99
sb10q commented 2023-02-08 19:41:44 +08:00
Outdated
Review
Copy Link

G99 is not a PWM fan.

G99 is not a PWM fan.
let fan = Timer::new(tim8, &clocks).pwm(gpioc.pc9.into_alternate(), 25u32.khz());
sb10q commented 2023-03-15 13:16:50 +08:00
Outdated
Review
Copy Link

Advised where? All the SUNON docs say PWM on this fan model isn't supported at all.

Advised where? All the SUNON docs say PWM on this fan model isn't supported at all.
sb10q commented 2023-03-15 13:17:16 +08:00
Outdated
Review
Copy Link

And what "higher frequency" are you talking about?

And what "higher frequency" are you talking about?
(pins, leds, eeprom, eth_pins, usb, fan)
}