M-Labs
/
thermostat
9
0
Fork 5
Code Issues 10 Pull Requests 7 Releases Wiki Activity

Use upstream stm32f4xx-hal #67

Merged
sb10q merged 4 commits from mwojcik/thermostat:hal-update into master 2022-03-02 17:21:18 +08:00
Conversation 2 Commits 4 Files Changed 9 +150 -93
mwojcik commented 2022-01-25 12:58:47 +08:00
Owner
Copy Link

This should close #59.

Version 0.10.1 was chosen as the earliest one that does have the required flash support features, with possibly least breaking changes (...still there were plenty).

Most notably:

  • stm32-eth also needed an update
  • rustc needed an update - chose the nightly from stm32f4xx-hal 0.10.1 release day

Plus few smaller changes, but nothing that would break any thermostat functionality (SPI, Eth, GPIO into_alternate got simplified API-wise).

Compiles both with cargo build --release and nix build, but I have not tested it (maybe @topquark12 would be so kind since he's got the hardware now? :)) - unfortunately this took me longer than I thought.

This should close #59. Version 0.10.1 was chosen as the earliest one that does have the required flash support features, with possibly least breaking changes (...still there were plenty). Most notably: - stm32-eth also needed an update - rustc needed an update - chose the nightly from stm32f4xx-hal 0.10.1 release day Plus few smaller changes, but nothing that would break any thermostat functionality (SPI, Eth, GPIO ``into_alternate`` got simplified API-wise). Compiles both with ``cargo build --release`` and ``nix build``, but I have not tested it (maybe @topquark12 would be so kind since he's got the hardware now? :)) - unfortunately this took me longer than I thought.
mwojcik added 4 commits 2022-01-25 12:58:49 +08:00
sb10q commented 2022-02-05 12:44:11 +08:00
Owner
Copy Link

@topquark12 any update on testing this?

@topquark12 any update on testing this?
topquark12 commented 2022-03-02 17:15:32 +08:00
Contributor
Copy Link

Hardware functions normally, can be merged.

Hardware functions normally, can be merged.
sb10q merged commit 5688b2f1bb into master 2022-03-02 17:21:18 +08:00
mwojcik deleted branch hal-update 2022-03-02 17:26:25 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#67
No description provided.
Delete Branch "mwojcik/thermostat:hal-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?