M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

nix flakes support #64

Merged
sb10q merged 7 commits from mwojcik/thermostat:nixflakes into master 2022-01-19 11:13:47 +08:00
Conversation 1 Commits 7 Files Changed 5 +43 -37
1 changed files with 43 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e749a96971 - Show all commits

50
flake.nix
View File

@ -27,45 +27,51 @@
rustc = rust; rustc = rust;
cargo = rust; cargo = rust;
}); });
cargoSha256 = "0qb4s06jwgj3i9df6qq9gwcnyr3jq6dh4l5ygjghq5x1bmcqliix"; thermostat = rustPlatform.buildRustPackage rec {
buildStm32Firmware = { name, src, cargoDepsName ? name, patchPhase ? "", extraNativeBuildInputs ? [], checkPhase ? "", doCheck ? true, binaryName ? name, extraCargoBuildArgs ? "" }: name = "thermostat";
rustPlatform.buildRustPackage rec {
inherit name cargoDepsName;
version = "0.0.0"; version = "0.0.0";
inherit src; src = self;
inherit cargoSha256; cargoLock = {
lockFile = ./Cargo.lock;
outputHashes = {
"stm32-eth-0.2.0" = "sha256-HXRr/NDhdIKqyjdA4D8ZmcO1dDpDawdlYPUOwcEbPQk=";
"stm32f4xx-hal-0.8.3" = "sha256-MOv7tVtVMxr3IYMaN0Q8EQWxv3rubmCxjXMXuw/ZKAw=";
};
};
inherit patchPhase; patchPhase = "";
sb10q commented 2022-01-17 18:07:40 +08:00
Outdated
Review
Copy Link

Remove?

Remove?
nativeBuildInputs = [ pkgs.llvm ] ++ extraNativeBuildInputs; nativeBuildInputs = [ pkgs.llvm ];
buildPhase = '' buildPhase = ''
sb10q commented 2022-01-18 11:05:16 +08:00
Review
Copy Link

cargoBuildFlags?

cargoBuildFlags?
mwojcik commented 2022-01-18 11:18:04 +08:00
Review
Copy Link

Is there API of that function described somewhere for quick reference? Besides the little tutorial section...

Is there API of that function described somewhere for quick reference? Besides the little tutorial section...
mwojcik commented 2022-01-18 11:27:27 +08:00
Review
Copy Link

Actually, using just cargoBuildFlags (--bin thermostat as release is already included) causes the build to fail, as the default builder forces --target=x86_64-linux.

Actually, using just cargoBuildFlags (``--bin thermostat`` as release is already included) causes the build to fail, as the default builder forces ``--target=x86_64-linux``.
sb10q commented 2022-01-18 11:38:40 +08:00
Review
Copy Link

One usually has to RTFS of nixpkgs for this kind of extended documentation :)
If there's no easy solution then overriding buildPhase is fine.

One usually has to RTFS of nixpkgs for this kind of extended documentation :) If there's no easy solution then overriding buildPhase is fine.
export CARGO_HOME=$(mktemp -d cargo-home.XXX) export CARGO_HOME=$(mktemp -d cargo-home.XXX)
sb10q commented 2022-01-17 18:08:22 +08:00
Outdated
Review
Copy Link

Is CARGO_HOME necessary? NAC3 doesn't use it.

Is CARGO_HOME necessary? NAC3 doesn't use it.
sb10q commented 2022-01-17 18:08:38 +08:00
Outdated
Review
Copy Link

You can use cargoBuildFlags instead.

You can use cargoBuildFlags instead.
cargo build --release --bin ${binaryName} ${extraCargoBuildArgs} cargo build --release --bin thermostat
'';
checkPhase = ''
cargo test --target=${pkgs.rust.toRustTarget pkgs.stdenv.targetPlatform};
sb10q commented 2022-01-17 18:09:55 +08:00
Outdated
Review
Copy Link

cargoTestFlags

cargoTestFlags
''; '';
inherit checkPhase doCheck;
# binaryName defaults to the `name` arg (i.e. the Rust package name); # binaryName defaults to the `name` arg (i.e. the Rust package name);
# it is used as the Cargo binary filename # it is used as the Cargo binary filename
sb10q commented 2022-01-17 18:10:34 +08:00
Outdated
Review
Copy Link

I don't understand this comment?

I don't understand this comment?
installPhase = '' installPhase = ''
mkdir -p $out $out/nix-support mkdir -p $out $out/nix-support
cp target/thumbv7em-none-eabihf/release/${binaryName} $out/${name}.elf cp target/thumbv7em-none-eabihf/release/thermostat $out/thermostat.elf
echo file binary-dist $out/${name}.elf >> $out/nix-support/hydra-build-products echo file binary-dist $out/thermostat.elf >> $out/nix-support/hydra-build-products
sb10q commented 2022-01-19 10:19:01 +08:00
Outdated
Review
Copy Link

rec not needed

rec not needed
llvm-objcopy -O binary target/thumbv7em-none-eabihf/release/${binaryName} $out/${name}.bin llvm-objcopy -O binary target/thumbv7em-none-eabihf/release/thermostat $out/thermostat.bin
sb10q commented 2022-01-19 10:19:11 +08:00
Outdated
Review
Copy Link

also here

also here
echo file binary-dist $out/${name}.bin >> $out/nix-support/hydra-build-products echo file binary-dist $out/thermostat.bin >> $out/nix-support/hydra-build-products
''; '';
dontFixup = true; dontFixup = true;
}; };
in { in rec {
packages.x86_64-linux = rec { packages.x86_64-linux = rec {
thermostat = buildStm32Firmware { inherit thermostat;
name = "thermostat";
src = self;
checkPhase = ''
cargo test --target=${pkgs.rust.toRustTarget pkgs.stdenv.targetPlatform};
'';
}; };
hydraJobs = {
inherit (packages.x86_64-linux) thermostat;
sb10q commented 2022-01-18 11:06:20 +08:00
Review
Copy Link

gcc?

gcc?
}; };
sb10q commented 2022-01-18 11:06:54 +08:00
Review
Copy Link

Did you test this? I think this doesn't work and you need python3.withPackages instead.

Did you test this? I think this doesn't work and you need ``python3.withPackages`` instead.
mwojcik commented 2022-01-18 11:18:34 +08:00
Review
Copy Link

Weirdly enough it seems to work

❯ nix develop

[spaqin@hera:~/m-labs/thermostat]$ python
Python 3.9.6 (default, Jun 28 2021, 08:57:49) 
[GCC 10.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> import matplotlib
>>>
Weirdly enough it seems to work ```shell ❯ nix develop [spaqin@hera:~/m-labs/thermostat]$ python Python 3.9.6 (default, Jun 28 2021, 08:57:49) [GCC 10.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import numpy >>> import matplotlib >>> ```
sb10q commented 2022-01-18 11:41:34 +08:00
Review
Copy Link

This is the lab computer and those packages are already included in the system Python. You can use nix develop --ignore-environment to isolate the system profile (see https://github.com/NixOS/nix/issues/4359).

This is the lab computer and those packages are already included in the system Python. You can use ``nix develop --ignore-environment`` to isolate the system profile (see https://github.com/NixOS/nix/issues/4359).
mwojcik commented 2022-01-18 11:43:10 +08:00
Review
Copy Link

Still available:

❯ nix develop --ignore-environment
bash-5.1$ python
Python 3.9.6 (default, Jun 28 2021, 08:57:49) 
[GCC 10.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import matplotlib
>>> import numpy 
>>>
Still available: ```shell ❯ nix develop --ignore-environment bash-5.1$ python Python 3.9.6 (default, Jun 28 2021, 08:57:49) [GCC 10.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import matplotlib >>> import numpy >>> ```
devShell.x86_64-linux = pkgs.mkShell { devShell.x86_64-linux = pkgs.mkShell {
name = "thermostat-dev-shell"; name = "thermostat-dev-shell";
buildInputs = with pkgs; [ buildInputs = with pkgs; [
@ -76,6 +82,6 @@
numpy matplotlib numpy matplotlib
]); ]);
}; };
defaultPackage.x86_64-linux = pkgs.python3.withPackages(ps: [ ]); defaultPackage.x86_64-linux = thermostat;
}; };
} }