M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

nix flakes support #64

Merged
sb10q merged 7 commits from mwojcik/thermostat:nixflakes into master 2022-01-19 11:13:47 +08:00
Conversation 1 Commits 7 Files Changed 5 +68 -76
1 changed files with 68 additions and 76 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit af9f3903be - Show all commits

8
flake.nix
View File

@ -40,19 +40,11 @@
};
};
patchPhase = "";
nativeBuildInputs = [ pkgs.llvm ];
sb10q commented 2022-01-17 18:07:40 +08:00
Outdated
Review
Copy Link

Remove?

Remove?
buildPhase = ''
export CARGO_HOME=$(mktemp -d cargo-home.XXX)
cargo build --release --bin thermostat
sb10q commented 2022-01-18 11:05:16 +08:00
Review
Copy Link

cargoBuildFlags?

cargoBuildFlags?
mwojcik commented 2022-01-18 11:18:04 +08:00
Review
Copy Link

Is there API of that function described somewhere for quick reference? Besides the little tutorial section...

Is there API of that function described somewhere for quick reference? Besides the little tutorial section...
mwojcik commented 2022-01-18 11:27:27 +08:00
Review
Copy Link

Actually, using just cargoBuildFlags (--bin thermostat as release is already included) causes the build to fail, as the default builder forces --target=x86_64-linux.

Actually, using just cargoBuildFlags (``--bin thermostat`` as release is already included) causes the build to fail, as the default builder forces ``--target=x86_64-linux``.
sb10q commented 2022-01-18 11:38:40 +08:00
Review
Copy Link

One usually has to RTFS of nixpkgs for this kind of extended documentation :)
If there's no easy solution then overriding buildPhase is fine.

One usually has to RTFS of nixpkgs for this kind of extended documentation :) If there's no easy solution then overriding buildPhase is fine.
'';
sb10q commented 2022-01-17 18:08:22 +08:00
Outdated
Review
Copy Link

Is CARGO_HOME necessary? NAC3 doesn't use it.

Is CARGO_HOME necessary? NAC3 doesn't use it.
sb10q commented 2022-01-17 18:08:38 +08:00
Outdated
Review
Copy Link

You can use cargoBuildFlags instead.

You can use cargoBuildFlags instead.
checkPhase = ''
cargo test --target=${pkgs.rust.toRustTarget pkgs.stdenv.targetPlatform};
'';
# binaryName defaults to the `name` arg (i.e. the Rust package name);
# it is used as the Cargo binary filename
installPhase = ''
mkdir -p $out $out/nix-support
cp target/thumbv7em-none-eabihf/release/thermostat $out/thermostat.elf