M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 7 Releases Wiki Activity

Reset all TCP sockets before MCU reset #53

Merged
sb10q merged 5 commits from tcp_reset into master 2021-01-26 17:45:14 +08:00
Conversation 0 Commits 5 Files Changed 1 +264 -249
topquark12 commented 2021-01-26 15:37:44 +08:00
Contributor
Copy Link

majority of changes starts at line 460

majority of changes starts at line 460
topquark12 added 3 commits 2021-01-26 15:37:44 +08:00
sb10q reviewed 2021-01-26 17:26:59 +08:00
src/main.rs Outdated
@ -460,0 +459,4 @@
});
} else {
// Should reset, close all TCP sockets.
let mut sockets_active = 0;
sb10q commented 2021-01-26 17:26:59 +08:00
Owner
Copy Link

This could be a boolean any_socket_active

This could be a boolean ``any_socket_active``
sb10q reviewed 2021-01-26 17:29:43 +08:00
src/main.rs Outdated
@ -460,0 +466,4 @@
sockets_active += 1;
}
});
// Must let loop run one more cycle to poll server in order for RST to be sent,
sb10q commented 2021-01-26 17:29:43 +08:00
Owner
Copy Link

let the loop run for one more cycle

let the loop run for one more cycle
topquark12 added 1 commit 2021-01-26 17:31:17 +08:00
topquark12 added 1 commit 2021-01-26 17:32:52 +08:00
sb10q merged commit 7cb0ed70be into master 2021-01-26 17:45:14 +08:00
topquark12 deleted branch tcp_reset 2021-01-26 17:46:33 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#53
No description provided.
Delete Branch "tcp_reset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?