M-Labs/thermostat
12
0
Fork 7
Code Issues 10 Pull Requests 15 Releases Wiki Activity

flash_store_refactor #49

Merged
sb10q merged 4 commits from flash_store_refactor into master 2021-01-13 17:30:12 +08:00
Conversation 2 Commits 4 Files Changed 2 +17 -5
topquark12 commented 2021-01-13 17:17:47 +08:00
Contributor
Copy Link

Remove memory offset magic number from flash store.

Remove memory offset magic number from flash store.
topquark12 added 3 commits 2021-01-13 17:17:47 +08:00
flash store: initial prototype a6466c847a
flash store: remove transmute cef9cf6f48
flash store: clean up 0200aa69bd
sb10q reviewed 2021-01-13 17:19:03 +08:00
src/flash_store.rs Outdated
@@ -15,3 +20,4 @@
flash: FLASH,
}
unsafe fn get_offset() -> usize {
sb10q commented 2021-01-13 17:19:03 +08:00
Owner
Copy Link

I suggest moving the unsafe block into this function and marking it safe.

I suggest moving the ``unsafe`` block into this function and marking it safe.
sb10q reviewed 2021-01-13 17:20:31 +08:00
memory.x Outdated
@@ -13,3 +13,5 @@ MEMORY
_stack_start = ORIGIN(CCMRAM) + LENGTH(CCMRAM);
_dfu_msg = ORIGIN(DFU_MSG);
_config_start = ORIGIN(CONFIG);
sb10q commented 2021-01-13 17:20:31 +08:00
Owner
Copy Link

Keep the same order as the declarations above.

Keep the same order as the declarations above.
topquark12 added 1 commit 2021-01-13 17:23:42 +08:00
flash store: move unsafe, organise memory.x 1c71fbb6a7
sb10q merged commit cf3ace4d2d into master 2021-01-13 17:30:12 +08:00
topquark12 deleted branch flash_store_refactor 2021-01-16 09:41:59 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
sb10q
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
atse bukehu dly fsagbuya jordens linuswck morgan mwojcik occheung saeed.r sb10q srenblad therobs12
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: M-Labs/thermostat#49
Delete Branch "flash_store_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?