M-Labs
/
thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

PID_improvements #45

Merged
sb10q merged 1 commits from PID_improvements into master 2024-08-17 17:37:18 +08:00
Conversation 0 Commits 1 Files Changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/channels.rs
View File

@ -364,12 +364,12 @@ impl Channels {
(duty * max, max) (duty * max, max)
} }
// Get actual current passing through TEC // Get current passing through TEC
sb10q commented 2021-01-11 16:13:58 +08:00
Outdated
Review
Copy Link

Actual?

Actual?
topquark12 commented 2021-01-11 16:18:41 +08:00
Outdated
Review
Copy Link

There are quite a few variables describing currents, like current setpoint, dac voltage setpoint controlling output current, dac voltage readback for current control.

This returns the thermostat measured current that is passing through the TEC, hence "actual".

There are quite a few variables describing currents, like current setpoint, dac voltage setpoint controlling output current, dac voltage readback for current control. This returns the thermostat measured current that is passing through the TEC, hence "actual".
topquark12 commented 2021-01-11 16:23:11 +08:00
Outdated
Review
Copy Link

I'll rephrase the comment for clarity.

I'll rephrase the comment for clarity.
pub fn get_tec_i(&mut self, channel: usize) -> ElectricCurrent { pub fn get_tec_i(&mut self, channel: usize) -> ElectricCurrent {
(self.read_itec(channel) - self.read_vref(channel)) / ElectricalResistance::new::<ohm>(0.4) (self.read_itec(channel) - self.read_vref(channel)) / ElectricalResistance::new::<ohm>(0.4)
} }
// Get actual voltage across TEC // Get voltage across TEC
pub fn get_tec_v(&mut self, channel: usize) -> ElectricPotential { pub fn get_tec_v(&mut self, channel: usize) -> ElectricPotential {
(self.read_tec_u_meas(channel) - ElectricPotential::new::<volt>(1.5)) * 4.0 (self.read_tec_u_meas(channel) - ElectricPotential::new::<volt>(1.5)) * 4.0
} }