M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

Derivative calculation was wrong all along #40

Merged
sb10q merged 1 commits from pid_hotfix into master 2020-12-29 17:09:04 +08:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
topquark12 commented 2020-12-29 17:06:43 +08:00
Contributor
Copy Link

Derivative should be (error - last_error), but because we're using input to calculate derivative to prevent kick, and the relationship between error and input is (error = target - input), using input for derivative caluculation means it should be calculated as (last_input-input).

Derivative should be (error - last_error), but because we're using input to calculate derivative to prevent kick, and the relationship between error and input is (error = target - input), using input for derivative caluculation means it should be calculated as (last_input-input).
sb10q merged commit e94601f54f into master 2020-12-29 17:09:04 +08:00
topquark12 deleted branch pid_hotfix 2020-12-29 17:30:29 +08:00
astro commented 2020-12-30 00:40:26 +08:00
First-time contributor
Copy Link

The PID controller implementation was taken in verbatim from Ionpak. Maybe it might make sense to backport some fixes.

The PID controller implementation was taken in verbatim from Ionpak. Maybe it might make sense to backport some fixes.
sb10q commented 2020-12-30 13:10:58 +08:00
Owner
Copy Link

Yes, ionpak generally needs an overhaul regarding this and a long list of other problems. I'm planning to look into it at some point.

Yes, ionpak generally needs an overhaul regarding this and a long list of other problems. I'm planning to look into it at some point.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#40
No description provided.
Delete Branch "pid_hotfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?