M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

cargo fmt and cargo clippy changes #141

Merged
sb10q merged 2 commits from atse/thermostat:cargo-fmt-clippy into master 2024-10-16 11:14:08 +08:00
Conversation 1 Commits 2 Files Changed 26 +1192 -987
atse commented 2024-10-14 16:24:37 +08:00
Contributor
Copy Link

Run cargo fmt and cargo clippy to clean up the Rust source code. Tested to boot on Thermostat v2.2.1.

Run `cargo fmt` and `cargo clippy` to clean up the Rust source code. Tested to boot on Thermostat v2.2.1.
atse added 2 commits 2024-10-14 16:24:37 +08:00
esavkin commented 2024-10-14 16:28:55 +08:00
Owner
Copy Link

It's nice to do, but maybe also add rustfmt.toml like in artiq-zynq? Also similar to it, add to hydra jobs, so it would run in CI and at least post-factum contributors would know that their formatting is off.
Rustfmt.toml can be also integrated with IDEs: https://www.jetbrains.com/help/rust/rustfmt.html#format-cargo-project

It's nice to do, but maybe also add rustfmt.toml like in artiq-zynq? Also similar to it, add to hydra jobs, so it would run in CI and at least post-factum contributors would know that their formatting is off. Rustfmt.toml can be also integrated with IDEs: https://www.jetbrains.com/help/rust/rustfmt.html#format-cargo-project
sb10q merged commit d8ec083dbc into master 2024-10-16 11:14:08 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#141
No description provided.
Delete Branch "atse/thermostat:cargo-fmt-clippy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?