M-Labs
/
thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

Fix wrong current limit duty cycle calculation #134

Merged
sb10q merged 1 commits from atse/thermostat:fix_wrong_current_limit_duty_cycle_cal into master 2024-09-25 17:20:29 +08:00
Conversation 0 Commits 1 Files Changed 1 +11 -9
atse commented 2024-09-23 18:01:51 +08:00
Contributor
Copy Link

max_i_pos and max_i_neg don't quite accurately limit current outputs.

This is because previous commits assumed setting 3.3V -> 3A current limit, which is wrong.

According to the MAX1968 datasheet,
Unsaved Image 2.png

`max_i_pos` and `max_i_neg` don't quite accurately limit current outputs. This is because previous commits assumed setting 3.3V -> 3A current limit, which is wrong. According to the MAX1968 datasheet, ![Unsaved Image 2.png](/attachments/0d455c27-1669-4cad-b956-2234a0081c07)
Unsaved Image 2.png
32 KiB
atse added 1 commit 2024-09-23 18:01:52 +08:00
5533576cf6 Fix wrong current limit duty cycle calculation 
- prev commit assumed setting 3.3V -> 3A current limit which is wrong
- Please refer to the MAX1968 datasheet for the duty cycle
calculation equation
sb10q merged commit ad54842c43 into master 2024-09-25 17:20:29 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#134
No description provided.
Delete Branch "atse/thermostat:fix_wrong_current_limit_duty_cycle_cal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?