M-Labs
/
thermostat
9
0
Fork 5
Code Issues 8 Pull Requests 14 Releases Wiki Activity

README: Fix command to make firmware BIN #115

Merged
sb10q merged 2 commits from atse/thermostat:readme-bin-path into master 2024-08-07 18:22:49 +08:00
Conversation 3 Commits 2 Files Changed 1 +1 -1
atse commented 2024-08-06 16:05:24 +08:00
Contributor
Copy Link

This reflects the actual command that needs to be run to make the firmware BIN from the repository root.

This reflects the actual command that needs to be run to make the firmware BIN from the repository root.
atse added 1 commit 2024-08-06 16:05:25 +08:00
esavkin commented 2024-08-07 10:19:17 +08:00
Owner
Copy Link

I feel it would be better to keep it in sync with nix build .#thermostat, i.e. change it to

llvm-objcopy -O binary target/thumbv7em-none-eabihf/release/thermostat thermostat.bin
I feel it would be better to keep it in sync with `nix build .#thermostat`, i.e. change it to ```sh llvm-objcopy -O binary target/thumbv7em-none-eabihf/release/thermostat thermostat.bin ```
sb10q commented 2024-08-07 16:08:09 +08:00
Owner
Copy Link

Agreed. You even sent a PR to install LLVM in the flake devshell, then you are not suggesting to use it in the README - this does not make sense.

Also, if arm-none-eabi-objcopy somehow gets installed, then please remove it, we don't need both of it and LLVM.

Agreed. You even sent a PR to install LLVM in the flake devshell, then you are not suggesting to use it in the README - this does not make sense. Also, if arm-none-eabi-objcopy somehow gets installed, then please remove it, we don't need both of it and LLVM.
atse commented 2024-08-07 17:50:03 +08:00
Author
Contributor
Copy Link

Yup, don't know how I missed this, changing. Also arm-none-eabi-objcopy isn't installed at all, probably an outdated doc.

Yup, don't know how I missed this, changing. Also arm-none-eabi-objcopy isn't installed at all, probably an outdated doc.
atse force-pushed readme-bin-path from 34ccf03370 to 8c9bd2ce29 2024-08-07 18:02:27 +08:00 Compare
atse changed title from README: Add full path to compiled binary to README: Fix command to make firmware BIN 2024-08-07 18:15:23 +08:00
sb10q merged commit 9d89104f50 into master 2024-08-07 18:22:49 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#115
No description provided.
Delete Branch "atse/thermostat:readme-bin-path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?