Clamp TEC Settings to Valid & Design Specs Ranges #108

linuswck · 2024-05-10T15:25:41+08:00

linuswck commented

2024-05-10 15:25:41 +08:00

This PR clamps the TEC output value according to design specs and a valid range. Upon test, you can make thermostat to enter an unrecoverable state if the output current is set to 3.0A while the specs points out the max current should be +-2.0A @4V

Also, the firmware should prevent the upper driver to set invalid value. For example, you should not be able to set_max_v to negative value.

Valid Range for TEC Settings related Command
set_i: -2A - 2A
set_max_v: 0-4V
set_max_i_pos: 0-4V
set_max_i_neg: 0-2A

Coverage Test is done with the cmd interface

This PR clamps the TEC output value according to [design specs](https://github.com/sinara-hw/Thermostat/wiki) and a valid range. Upon test, you can make thermostat to enter an unrecoverable state if the output current is set to 3.0A while the specs points out the max current should be +-2.0A @4V Also, the firmware should prevent the upper driver to set invalid value. For example, you should not be able to set_max_v to negative value. Valid Range for TEC Settings related Command set_i: -2A - 2A set_max_v: 0-4V set_max_i_pos: 0-4V set_max_i_neg: 0-2A Coverage Test is done with the cmd interface

linuswck added 1 commit 2024-05-10 15:25:41 +08:00

1007982b48 clamp TEC settings to a valid & design specs range

- Not respecting the design specs can cause hardware to get stuck in unrecoverable state

sb10q merged commit 1007982b48 into master

2024-05-10 16:54:19 +08:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#108