Add swap command #104
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "atse/thermostat:swap_tec_polarity"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
For use with Zotino, since the Zotino header on the Thermostat has the current pins reversed.
@ -414,1 +414,4 @@
fn swap_tec_polarity (socket: &mut TcpSocket, channels: &mut Channels, channel: Option<usize>) -> Result<Handler, Error> {
for c in 0..CHANNELS {
if channel.is_none() || channel == Some(c) {
Isn't there a way to set it directly into channel_state?
@ -122,0 +122,4 @@
-i_set
} else {
i_set
}
Can't it be handled just at the DAC and current readout, instead of having to invert it all over the place?
@ -415,0 +415,4 @@
fn swap_tec_polarity (socket: &mut TcpSocket, channels: &mut Channels, channel: Option<usize>) -> Result<Handler, Error> {
for c in 0..CHANNELS {
if channel.is_none() || channel == Some(c) {
channels.channel_state(c).swap_tec_polarity = !channels.channel_state(c).swap_tec_polarity;
That's a terrible API. Simply add a way to set swapped to true/false (with the reference being the front panel polarity) instead of only something that toggles the property without any way to know what its value is.
Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Gitea.