warn when current/voltage limits are at 0 #72
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Proposed features
Emit warning messages to the log and all TCP sessions once, on the case: any of the max_v, max_i_pos, max_i_neg of any channel is set to zero+-EPSILON by pwm command.
Emit warning messages to the newly created TCP session once, on the case: client connected by TCP, and any of the max_v, max_i_pos, max_i_neg of any channel is equal to zero+-EPSILON.
All above cases should emit one message per zeroed
channel:variable
pair.Message format
For TCP sessions, message should be in machine-readable format (JSON):
For the log:
The log is only used for development AFAIK and this is a user feature, so we can skip the log part.
Might be easier and cleaner to do client-side.
I doubt it would be far easier. What should happen on multiuser case? If that's would be pure client feature, that would be either of these:
max_v, max_i_pos, max_i_neg
is near zero, emits warning message to the STDERR.max_v, max_i_pos, max_i_neg
is near zero, emits warning message to the STDERR.set_param
only, and once any of themax_v, max_i_pos, max_i_neg
is near zero, emits warning message to the STDERR.From server-side though, it could effectively send to all tcp channels the warnings once the values changed.
The intended purpose here is to tell the user what to do when bringing up a Thermostat with the default values at zero. No need to make this overly complicated. If there are multiple connections we can assume the user knows what they are doing already.
So overall proposed feature is this?
Client requests for values on its construction, and once any of the
max_v
,max_i_pos
,max_i_neg
on any channel is near zero, emits warning message to the STDERR:Yes, something like that. And the equivalent in the GUI