M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

fix inconsistent variables/units in README #19

New Issue
Closed
opened 2020-12-08 10:15:31 +08:00 by sb10q · 1 comment
sb10q commented 2020-12-08 10:15:31 +08:00
Owner
Copy Link

This mixes up "ratio", "ampere" and "volts". Also check that similar mistakes are not made in the source.

pwm <0/1> max_i_pos <ratio> 	Set PWM duty cycle for max_i_pos to ampere
pwm <0/1> max_i_neg <ratio> 	Set PWM duty cycle for max_i_neg to ampere
pwm <0/1> max_v <ratio> 	Set PWM duty cycle for max_v to volt
pwm <0/1> <volts> 	Disengage PID, set i_set DAC to ampere
This mixes up "ratio", "ampere" and "volts". Also check that similar mistakes are not made in the source. ```text pwm <0/1> max_i_pos <ratio> Set PWM duty cycle for max_i_pos to ampere pwm <0/1> max_i_neg <ratio> Set PWM duty cycle for max_i_neg to ampere pwm <0/1> max_v <ratio> Set PWM duty cycle for max_v to volt pwm <0/1> <volts> Disengage PID, set i_set DAC to ampere ```
astro commented 2020-12-09 08:39:19 +08:00
Copy Link

b92a5f18cd

The source uses uom types.

b92a5f18cd66f1f838af746c6477ba1a8a19ad61 The source uses uom types.
astro closed this issue 2020-12-09 08:39:19 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#19
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?