save does not preserve pid_engaged #17

New Issue

jbqubit · 2020-12-05T09:47:48+08:00

jbqubit commented

2020-12-05 09:47:48 +08:00

Expectation: Last saved state is loaded upon power-on. Temperature servo continues after power interruption.

Observation: Many parameters from saved state are preserved after power cycle but pid_engaged status is not. It is reset to false.

Expectation: Last saved state is loaded upon power-on. Temperature servo continues after power interruption. Observation: Many parameters from saved state are preserved after power cycle but ```pid_engaged``` status is not. It is reset to ```false```.

astro commented

2020-12-08 06:26:58 +08:00

I did not expect the device to be operated without control.

I need some time to make room in the config serialization because we already max out the available 128 bytes of EEPROM.

I did not expect the device to be operated without control. I need some time to make room in the config serialization because we already max out the available 128 bytes of EEPROM.

jbqubit commented

2020-12-08 08:38:17 +08:00

Fully autonomous operation is highly desirable. Once initial configuration is complete it will be rare to work with Thermostat interactively. Ideally this recovers after power failure and continue servoing.

sb10q commented

2020-12-08 10:04:17 +08:00

There's also the option of ignoring the EEPROM and storing into the flash, like it's done in ARTIQ:
https://github.com/m-labs/artiq/blob/master/artiq/firmware/libboard_misoc/config.rs

This code implements a simple key-value store that minimizes the number of times the flash sector is erased.

@occheung may have looked into this on STM32 already. I can see this being used on multiple boards, so maybe we should split it from ARTIQ and make it a separate library.

There's also the option of ignoring the EEPROM and storing into the flash, like it's done in ARTIQ: https://github.com/m-labs/artiq/blob/master/artiq/firmware/libboard_misoc/config.rs This code implements a simple key-value store that minimizes the number of times the flash sector is erased. @occheung may have looked into this on STM32 already. I can see this being used on multiple boards, so maybe we should split it from ARTIQ and make it a separate library.

👍 1

astro referenced this issue from a commit

2020-12-13 09:43:01 +08:00

config: save/store pid_engaged Fixes Gitea issue #17

astro closed this issue

2020-12-14 06:21:09 +08:00

Sign in to join this conversation.