M-Labs/nix-scripts
9
0
Fork 9
Code Issues 6 Pull Requests Releases Wiki Activity

commit and CI notifications to mattermost/IRC #3

New Issue
Closed
opened 2019-04-19 13:23:45 +08:00 by sb10q · 2 comments
sb10q commented 2019-04-19 13:23:45 +08:00
Owner
Copy Link

either:

  1. patch this to make it compatible with Github payloads: 2ca222033c/app/webhook.go (see https://github.com/mattermost/mattermost-server/issues/2017)
  2. run another server https://github.com/softdevteam/mattermost-github-integration - this is not already packaged for NixOS so this has to be done too.

Solution 1. is probably faster to do and it is less bloated, and we should be able to use package = pkgs.mattermost.overrideAttrs(...) in configuration.nix to automatically apply the patch and recompile when mattermost is updated.

either: 1. patch this to make it compatible with Github payloads: https://github.com/mattermost/mattermost-server/blob/2ca222033cfd1d10f5e72228356665e4dbe31a55/app/webhook.go (see https://github.com/mattermost/mattermost-server/issues/2017) 2. run another server https://github.com/softdevteam/mattermost-github-integration - this is not already packaged for NixOS so this has to be done too. Solution 1. is probably faster to do and it is less bloated, and we should be able to use ``package = pkgs.mattermost.overrideAttrs(...)`` in ``configuration.nix`` to automatically apply the patch and recompile when mattermost is updated.
astro commented 2019-04-26 06:26:25 +08:00
Contributor
Copy Link

I arbitrarily chose solution 2 due to a much smaller codebase.

I added to the nixbld configuration with a vhost of hooks.m-labs.hk. You need to add a DNS entry for this one. Alternatively, we could add this with a location in another nginx vhost. One vhost per service looks more clear to me.

You need to edit the nixbld-etc-nixos/mattermost-github-integration/config.py. (I cannot setup mattermost integrations, or can I?)

Note that there is a SECRET in that config.py which should probably not be public.

I arbitrarily chose solution 2 due to a much smaller codebase. I added to the nixbld configuration with a vhost of `hooks.m-labs.hk`. You need to add a DNS entry for this one. Alternatively, we could add this with a `location` in another nginx vhost. One vhost per service looks more clear to me. You need to edit the `nixbld-etc-nixos/mattermost-github-integration/config.py`. (I cannot setup mattermost integrations, or can I?) Note that there is a `SECRET` in that `config.py` which should probably not be public.
sb10q commented 2019-04-26 19:05:19 +08:00
Author
Owner
Copy Link

Thanks

Thanks
sb10q closed this issue 2019-04-26 19:05:19 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nix-scripts#3
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?