M-Labs
/
nalgebra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update src/geometry/scale.rs 

Co-authored-by: Sébastien Crozet <sebastien@crozet.re>
This commit is contained in:
Yuri6037 2021-10-24 20:31:35 +02:00 committed by GitHub
parent f7eec7317c
commit ded853757c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/geometry/scale.rs
View File

@ -284,17 +284,15 @@ impl<T: Scalar, const D: usize> Scale<T, D> {
DefaultAllocator: Allocator<T, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>
+ Allocator<T, DimNameSum<Const<D>, U1>, U1>,
{
// Unfortunately rust refuses at all costs to allow calling .to_homogeneous on a SVector
// (self.vector) so I had to do a manual copy in a new OVector
// The exact error is that to_homogeneous when called on a SVector requires DimAdd on Const<D>
// not DimNameAdd which will strangely bring rust into thinking that DimNameAdd is a
// trait object and no longer a generic parameter.
let mut v = OVector::<T, DimNameSum<Const<D>, U1>>::from_element(T::one());
// TODO: use self.vector.push() instead. We can’t right now because
// that would require the DimAdd bound (but here we use DimNameAdd).
// This should be fixable once Rust gets a more complete support of
// const-generics.
let mut v = OVector::from_element(T::one());
for i in 0..D {
v[(i, 0)] = self.vector[(i, 0)].clone();
v[i] = self.vector[i].clone();
}
return OMatrix::<T, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>::from_diagonal(&v);
}
return OMatrix::from_diagonal(&v);
/// Inverts `self` in-place.
///