M-Labs
/
nalgebra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove implementations of `Rotation`, `Translation` and `Transformation` for the `Identity` type. 

Because most of their methods did not make sence for the (constant) identity matrix, they were set
to `panic!` at runtime whenever the user tried to use them. Instead, it is much safer to completely
forbid their use by removing the related trait implementation.

See sebcrozet/ncollide#87.
This commit is contained in:
Sébastien Crozet 2015-07-07 22:40:14 +02:00
parent 705a969e6d
commit c13b0388ef
2 changed files with 3 additions and 115 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -10,7 +10,7 @@ bench:
cargo bench
doc:
cargo doc
cargo doc --no-deps
clean:
cargo clean

116
src/structs/spec/identity.rs
View File

@ -1,9 +1,8 @@
use std::ops::Mul;
use num::{Zero, One};
use num::One;
use structs::mat;
use traits::operations::{Inv, Transpose};
use traits::geometry::{Translation, Translate, Rotation, Rotate, Transformation, Transform,
AbsoluteRotate};
use traits::geometry::{Translate, Rotate, Transform, AbsoluteRotate};
impl One for mat::Identity {
#[inline]
@ -42,43 +41,6 @@ impl Transpose for mat::Identity {
}
}
impl<V: Zero> Translation<V> for mat::Identity {
#[inline]
fn translation(&self) -> V {
::zero()
}
#[inline]
fn inv_translation(&self) -> V {
::zero()
}
#[inline]
fn append_translation_mut(&mut self, _: &V) {
panic!("Attempted to translate the identity matrix.")
}
#[inline]
fn append_translation(&self, _: &V) -> mat::Identity {
panic!("Attempted to translate the identity matrix.")
}
#[inline]
fn prepend_translation_mut(&mut self, _: &V) {
panic!("Attempted to translate the identity matrix.")
}
#[inline]
fn prepend_translation(&self, _: &V) -> mat::Identity {
panic!("Attempted to translate the identity matrix.")
}
#[inline]
fn set_translation(&mut self, _: V) {
panic!("Attempted to translate the identity matrix.")
}
}
impl<V: Clone> Translate<V> for mat::Identity {
#[inline]
fn translate(&self, v: &V) -> V {
@ -91,43 +53,6 @@ impl<V: Clone> Translate<V> for mat::Identity {
}
}
impl<V: Zero> Rotation<V> for mat::Identity {
#[inline]
fn rotation(&self) -> V {
::zero()
}
#[inline]
fn inv_rotation(&self) -> V {
::zero()
}
#[inline]
fn append_rotation_mut(&mut self, _: &V) {
panic!("Attempted to rotate the identity matrix.")
}
#[inline]
fn append_rotation(&self, _: &V) -> mat::Identity {
panic!("Attempted to rotate the identity matrix.")
}
#[inline]
fn prepend_rotation_mut(&mut self, _: &V) {
panic!("Attempted to rotate the identity matrix.")
}
#[inline]
fn prepend_rotation(&self, _: &V) -> mat::Identity {
panic!("Attempted to rotate the identity matrix.")
}
#[inline]
fn set_rotation(&mut self, _: V) {
panic!("Attempted to rotate the identity matrix.")
}
}
impl<V: Clone> Rotate<V> for mat::Identity {
#[inline]
fn rotate(&self, v: &V) -> V {
@ -147,43 +72,6 @@ impl<V: Clone> AbsoluteRotate<V> for mat::Identity {
}
}
impl<M: One> Transformation<M> for mat::Identity {
#[inline]
fn transformation(&self) -> M {
::one()
}
#[inline]
fn inv_transformation(&self) -> M {
::one()
}
#[inline]
fn append_transformation_mut(&mut self, _: &M) {
panic!("Attempted to transform the identity matrix.")
}
#[inline]
fn append_transformation(&self, _: &M) -> mat::Identity {
panic!("Attempted to transform the identity matrix.")
}
#[inline]
fn prepend_transformation_mut(&mut self, _: &M) {
panic!("Attempted to transform the identity matrix.")
}
#[inline]
fn prepend_transformation(&self, _: &M) -> mat::Identity {
panic!("Attempted to transform the identity matrix.")
}
#[inline]
fn set_transformation(&mut self, _: M) {
panic!("Attempted to transform the identity matrix.")
}
}
impl<V: Clone> Transform<V> for mat::Identity {
#[inline]
fn transform(&self, v: &V) -> V {