M-Labs
/
nalgebra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #777 from dimforge/dot_segfault 

Add missing dot-product dimension check.
This commit is contained in:
Sébastien Crozet 2020-10-13 17:49:45 +02:00 committed by GitHub
parent 07dc799bbd 4da2bfcb71
commit b773fee897
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/base/blas.rs
View File

@ -289,6 +289,13 @@ where
rhs.shape(), rhs.shape(),
); );
assert!(
self.ncols() == rhs.ncols(),
"Dot product dimensions mismatch for shapes {:?} and {:?}: left cols != right cols.",
self.shape(),
rhs.shape(),
);
// So we do some special cases for common fixed-size vectors of dimension lower than 8 // So we do some special cases for common fixed-size vectors of dimension lower than 8
// because the `for` loop below won't be very efficient on those. // because the `for` loop below won't be very efficient on those.
if (R::is::<U2>() || R2::is::<U2>()) && (C::is::<U1>() || C2::is::<U1>()) { if (R::is::<U2>() || R2::is::<U2>()) && (C::is::<U1>() || C2::is::<U1>()) {