From b0a9eab0b996be6d7c6fdc47bf24f9ef2611f83a Mon Sep 17 00:00:00 2001 From: sebcrozet Date: Tue, 19 Mar 2019 22:52:57 +0100 Subject: [PATCH] Final SVD fix. --- src/linalg/householder.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/linalg/householder.rs b/src/linalg/householder.rs index d04da188..1dc0f7b6 100644 --- a/src/linalg/householder.rs +++ b/src/linalg/householder.rs @@ -36,7 +36,8 @@ pub fn reflection_axis_mut>( column.unscale_mut(factor.sqrt()); (-signed_norm, true) } else { - (-signed_norm, false) + // FIXME: not sure why we don't have a - sign here. + (signed_norm, false) } }