M-Labs
/
nalgebra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the criterion dependency and add comment to re-add it to run benchmarks. 

We are forced to remove the dependency because of the Cargo bug https://github.com/rust-lang/cargo/issues/4866 that would break compilation for #[no-std].

In practice, this means benchmarks will not compile any more unless we manually uncomment the criterion dependency.
This commit is contained in:
sebcrozet 2019-03-31 13:32:09 +02:00
parent 7dbff7c389
commit 86fa4bee52
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Cargo.toml
View File

@ -54,9 +54,11 @@ alga = { git = "https://github.com/rustsim/alga", branch = "dev" }
[dev-dependencies] [dev-dependencies]
serde_json = "1.0" serde_json = "1.0"
rand_xorshift = "0.1" rand_xorshift = "0.1"
# Newer vesrion of criterion make the compilation with no-std fail. ### Uncomment this line before running benchmarks.
# This problem is partly due to https://github.com/rust-lang/cargo/issues/1796 ### We can't just let this uncommented because that would breack
criterion = "=0.2.7" ### compilation for #[no-std] because of the terrible Cargo bug
### https://github.com/rust-lang/cargo/issues/4866
#criterion = "0.2.10"
[workspace] [workspace]
members = [ "nalgebra-lapack", "nalgebra-glm" ] members = [ "nalgebra-lapack", "nalgebra-glm" ]