M-Labs
/
nalgebra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Test for axes with zero magnitude

This commit is contained in:
Rasmus Brönnegård 2023-11-09 01:20:44 +01:00
parent 03c24fb369
commit 7ea9ecee08
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/linalg/bidiagonal.rs
View File

@ -8,6 +8,7 @@ use simba::scalar::ComplexField;
use crate::geometry::Reflection; use crate::geometry::Reflection;
use crate::linalg::householder; use crate::linalg::householder;
use crate::num::Zero;
use std::mem::MaybeUninit; use std::mem::MaybeUninit;
/// The bidiagonalization of a general matrix. /// The bidiagonalization of a general matrix.
@ -227,7 +228,10 @@ where
for i in (0..dim - shift).rev() { for i in (0..dim - shift).rev() {
let axis = self.uv.view_range(i + shift.., i); let axis = self.uv.view_range(i + shift.., i);
// TODO: sometimes, the axis might have a zero magnitude. // Sometimes, the axis might have a zero magnitude.
if axis.magnitude().is_zero() {
continue;
}
let refl = Reflection::new(Unit::new_unchecked(axis), T::zero()); let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
let mut res_rows = res.view_range_mut(i + shift.., i..); let mut res_rows = res.view_range_mut(i + shift.., i..);
@ -263,7 +267,10 @@ where
let axis = self.uv.view_range(i, i + shift..); let axis = self.uv.view_range(i, i + shift..);
let mut axis_packed = axis_packed.rows_range_mut(i + shift..); let mut axis_packed = axis_packed.rows_range_mut(i + shift..);
axis_packed.tr_copy_from(&axis); axis_packed.tr_copy_from(&axis);
// TODO: sometimes, the axis might have a zero magnitude. // Sometimes, the axis might have a zero magnitude.
if axis_packed.magnitude().is_zero() {
continue;
}
let refl = Reflection::new(Unit::new_unchecked(axis_packed), T::zero()); let refl = Reflection::new(Unit::new_unchecked(axis_packed), T::zero());
let mut res_rows = res.view_range_mut(i.., i + shift..); let mut res_rows = res.view_range_mut(i.., i + shift..);