diff --git a/nalgebra-glm/src/gtx/vector_query.rs b/nalgebra-glm/src/gtx/vector_query.rs index a0b9f621..e9fef7b3 100644 --- a/nalgebra-glm/src/gtx/vector_query.rs +++ b/nalgebra-glm/src/gtx/vector_query.rs @@ -9,7 +9,7 @@ use crate::traits::Number; /// /// * [`are_collinear2d()`] pub fn are_collinear(v0: &TVec3, v1: &TVec3, epsilon: T) -> bool { - is_null(&v0.cross(v1), epsilon) + abs_diff_eq!(v0.cross(v1), TVec3::::zeros(), epsilon = epsilon) } /// Returns `true` if two 2D vectors are collinear (up to an epsilon). @@ -48,6 +48,6 @@ pub fn is_normalized(v: &TVec, epsilon: T) } /// Returns `true` if `v` is zero (up to an epsilon). -pub fn is_null(v: &TVec, epsilon: T) -> bool { - abs_diff_eq!(*v, TVec::::zeros(), epsilon = epsilon) +pub fn is_null(v: &TVec, epsilon: T) -> bool { + abs_diff_eq!(v.norm_squared(), T::zero(), epsilon = epsilon * epsilon) }