AugAssignment & Default Parameter Support, and Polymorphism FIxes #95

ychenfo · 2021-11-12T03:54:25+08:00

ychenfo commented

2021-11-12 03:54:25 +08:00

Add augassign statement support
Constant primitive default parameter support
Fix polymorphic class method partial instantiation (typevars occuring only in class methods but not in class declarations are now handled correctly)
Fix rigid typevar (typevars without bound should now be able to be handled properly)
Symbol resolver in nac3artiq and standalone now can handle typevar with forward ref
Add virtual in min_artiq

Related to inheritance, super().__init__() are not supported yet (in nac3standalone, we need to manually initialize the base class attributes in the child class' constructor)... But in situations in nac3artiq where class objects are initilized on the host side this should not be a very big problem.

- Add augassign statement support - Constant primitive default parameter support - Fix polymorphic class method partial instantiation (typevars occuring only in class methods but not in class declarations are now handled correctly) - Fix rigid typevar (typevars without bound should now be able to be handled properly) - Symbol resolver in nac3artiq and standalone now can handle typevar with forward ref - Add `virtual` in min_artiq ----- Related to inheritance, `super().__init__()` are not supported yet (in nac3standalone, we need to manually initialize the base class attributes in the child class' constructor)... But in situations in nac3artiq where class objects are initilized on the host side this should not be a very big problem.

ychenfo added 17 commits 2021-11-12 03:54:26 +08:00

nac3core: AugAssign support 7def83c026

nac3core: default constant parameter support a58600d702

nac3core: fix polymorphic class method partial instantiation a758cc740b

nac3core: top level use codegen official get_subst_key bbeb66e24a

nac3artiq: symbol reslover handle typevar, virtual and ForwardRef 9756fa75f6

nac3standalone: basic resolver typevar handling 4424418623

nac3core: parse type annotation python forwardref handling 0e355c6a52

nac3artiq: avoid using py.eval to get id of class virtual b7a2d02f27

nac3core: fix handling on rigid typevar f5536c9218

nac3core: fix broken tests due to the fix of rigid typevar handling dbe8082f25

nac3artiq: remove unnecessary python print from helper 2320c1b96a

nac3standalone: add polymorphism and default parameter demo c96cf40012

nac3standalone: report when entry point run function cannot be found 87a5b24975

nac3artiq: add polymorphism demo 0adc119e0c

nac3artiq, standalone: demo add augassign 494bd9dd78

nac3core: composer better error msg in for uninit field 476c4b125b

nac3artiq, standalone: update demo 24f6a86ec5

sb10q commented

2021-11-13 12:25:30 +08:00

I cherry-picked the first commit because it seemed simple enough and would solve a lot of practical problems.
For the others, please split them into separate self-contained functional PRs for easier review.

I cherry-picked the first commit because it seemed simple enough and would solve a lot of practical problems. For the others, please split them into separate self-contained functional PRs for easier review.

sb10q reviewed 2021-11-13 12:26:12 +08:00

nac3core/src/toplevel/composer.rs

						
				@ -1068,2 +1069,2 @@

				                        args.args

				                        let mut arg_with_defualt: Vec<(&ast::Located<ast::ArgData<()>>, Option<&ast::Expr>)> = args

sb10q commented

2021-11-13 12:26:12 +08:00

typo

sb10q reviewed 2021-11-13 12:26:31 +08:00

nac3core/src/toplevel/composer.rs

						
				@ -1321,1 +1361,3 @@

				                                    default_value: None,

				                                    default_value: default.map(|default| {

				                                        if name == "self".into() {

				                                            panic!("`self` parameter cannot take default value at {}", x.location)

sb10q commented

2021-11-13 12:26:31 +08:00

Return an error instead of calling panic!

Return an error instead of calling ``panic!``

sb10q reviewed 2021-11-13 12:27:08 +08:00

nac3standalone/src/main.rs

						
				@ -69,0 +97,4 @@

				                    );

				                    internal_resolver.add_id_type(

				                        if let ExprKind::Name { id, .. } = &targets[0].node { *id } else {

				                            panic!("must assign simple name variable as type variable for now")

sb10q commented

2021-11-13 12:27:08 +08:00

Remove "for now".

sb10q reviewed 2021-11-13 12:27:33 +08:00

nac3core/src/toplevel/helper.rs

						
				@ -344,0 +362,4 @@

				                Constant::Tuple(tuple) => Ok(SymbolValue::Tuple(

				                    tuple.iter().map(|x| handle_constant(x, loc)).collect::<Result<Vec<_>, _>>()?

				                )),

				                _ => unimplemented!("this constant is not supported now at {}", loc),

sb10q commented

2021-11-13 12:27:33 +08:00

remove "now"

sb10q commented

2021-11-19 12:58:25 +08:00

Should we close this PR?

@ychenfo can you keep breaking down the remaining changes into separate PRs, and then delete the range_with_class branch?

Should we close this PR? @ychenfo can you keep breaking down the remaining changes into separate PRs, and then delete the ``range_with_class`` branch?

ychenfo commented

2021-11-20 05:36:43 +08:00

Should we close this PR?

Yes, this PR can be closed.

@ychenfo can you keep breaking down the remaining changes into separate PRs, and then delete the range_with_class branch?

Sure, but can I do this after the current two PRs is merged? Otherwise I think there seems to be quite a few contents that might cause some conflicts. I will create new PRs as soon as I.

> Should we close this PR? Yes, this PR can be closed. > @ychenfo can you keep breaking down the remaining changes into separate PRs, and then delete the ``range_with_class`` branch? Sure, but can I do this after the current two PRs is merged? Otherwise I think there seems to be quite a few contents that might cause some conflicts. I will create new PRs as soon as I.

sb10q closed this pull request

2021-11-20 13:48:32 +08:00