nac3artiq: implement module type support #573

abdul124 · 2025-01-16T14:07:25+08:00

abdul124 commented

2025-01-16 14:07:25 +08:00

This PR adds:

module type support with aliasing
support for global variables in nac3artiq

Supported use cases are illustrated in nac3artiq.demo.module_support.
Solves #40

This PR adds: - module type support with aliasing - support for global variables in nac3artiq Supported use cases are illustrated in `nac3artiq.demo.module_support`. Solves #40

abdul124 added 9 commits 2025-01-16 14:07:25 +08:00

[core] add attributes to class string 4bd5349381

[core] add module type febfd1241d

[artiq] add module primitive type 7fac801936

[artiq] register modules f15a64cc1b

[core] add module type ce40a46f8a

[artiq] add global variables to modules 32f24261f2

[core] implement codegen for modules 5fdbc34b43

update snapshots 14e80dfab7

[artiq] add tests for module support 879b063968

abdul124 requested review from derppening 2025-01-16 14:07:46 +08:00

derppening approved these changes 2025-01-16 15:09:55 +08:00

derppening requested review from sb10q 2025-01-16 15:10:00 +08:00

derppening commented

2025-01-16 15:10:15 +08:00

Please make sure cargo fmt is run before merge.

Please make sure `cargo fmt` is run before merge.

sb10q commented

2025-01-17 12:40:33 +08:00

Needs cleanup pass of nac3artiq/demo. This PR makes the existing mess worse, merge first then clean up everything.

sb10q merged commit 879b063968 into master

2025-01-17 12:40:41 +08:00

abdul124 referenced this pull request

2025-01-20 10:28:23 +08:00

artiq: move unrelated tests to standalone #574

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#573