M-Labs/nac3
M-Labs/nac3
8
1
Fork 13
Code Issues 100 Pull Requests 5 Releases Wiki Activity

ndstrides: [12] Reimplement builtins #522

Closed
lyken wants to merge 3 commits from ndstrides-12-builtins into ndstrides-11-matmul
pull from: ndstrides-12-builtins
merge into: M-Labs:ndstrides-11-matmul
Conversation 2 Commits 3 Files Changed 3 +785 -1068
lyken commented 2024-08-28 14:21:23 +08:00
Collaborator
Copy Link

Update codegen/builtin_fns.rs to use ndarray with strides.

The struct ContiguousNDArray is the legacy NDArray's definition. nalgebra utilities uses the legacy definition for its ABI. Therefore it is needed.

After this PR, nac3standalone/demo/src/ndarray.py will be runnable.

Update `codegen/builtin_fns.rs` to use ndarray with strides. The struct `ContiguousNDArray` is the legacy `NDArray`'s definition. `nalgebra` utilities uses the legacy definition for its ABI. Therefore it is needed. After this PR, `nac3standalone/demo/src/ndarray.py` will be runnable.
lyken added 3 commits 2024-08-28 14:21:24 +08:00 
Currently this is used to interop with nalgebra.
lyken added a new dependency 2024-08-28 14:21:29 +08:00
#521 ndstrides: [11] Implement general matmul & `np_dot()`
lyken added a new dependency 2024-08-28 14:25:24 +08:00
#523 ndstrides: [13] Enhance `ndarray.py` tests
lyken force-pushed ndstrides-12-builtins from cd41b03dd5 to 7fb5e10ee2 2024-08-30 15:14:43 +08:00 Compare
lyken commented 2024-08-30 15:14:47 +08:00
Author
Collaborator
Copy Link

Rebased.

Rebased.
derppening force-pushed ndstrides-12-builtins from 7fb5e10ee2 to 4e57a82543 2024-10-18 14:41:23 +08:00 Compare
derppening force-pushed ndstrides-12-builtins from 4e57a82543 to 4ac881ccf6 2024-10-18 14:45:31 +08:00 Compare
derppening force-pushed ndstrides-12-builtins from 4ac881ccf6 to 7f3c45302d 2024-10-18 15:02:25 +08:00 Compare
derppening commented 2025-01-06 16:51:25 +08:00
Collaborator
Copy Link

Superseded by #568.

Superseded by #568.
derppening closed this pull request 2025-01-06 16:51:27 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#523 ndstrides: [13] Enhance `ndarray.py` tests
M-Labs/nac3
Depends on
#521 ndstrides: [11] Implement general matmul & `np_dot()`
M-Labs/nac3
Reference: M-Labs/nac3#522
No description provided.
Delete Branch "ndstrides-12-builtins"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?