M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 8
Code Issues 100 Pull Requests 20 Releases Wiki Activity

ndstrides: [9] Implement ndarray subscript assignment #519

Open
lyken wants to merge 2 commits from ndstrides-9-subassign into ndstrides-8-transpose
pull from: ndstrides-9-subassign
merge into: M-Labs:ndstrides-8-transpose
Conversation 1 Commits 2 Files Changed 2 +130 -2
lyken commented 2024-08-28 14:08:10 +08:00
Collaborator
Copy Link

Implemented general ndarray subscript assignment with referential integrity.

  • For example, you can do funky things like np_transpose(np_transpose(my_array)[::3])[0, 2:100] = 1.0 and my_array would update. This is only possible with ndarray with strides.
  • Solves #411 (Implement subscript-assignment for NDArray) in a different way than described in the issue.

There is no implementation to handle overlapping at the moment. Things like

xs = np_array([1, 2, 3, 4, 5, 6])
xs[::] = xs[::-1]

have undefined behavior at this moment because the current implementation is a naive memcpy from the source to the destination. I think an addition to fix this after ndstrides is completed should be fine.

ScalarOrNDArray is a utility to deal with implementing ndarray-related logics that deals with both scalars and ndarrays simultaneously.

Implemented general ndarray subscript assignment with referential integrity. - For example, you can do funky things like `np_transpose(np_transpose(my_array)[::3])[0, 2:100] = 1.0` and `my_array` would update. This is only possible with ndarray with strides. - Solves https://git.m-labs.hk/M-Labs/nac3/issues/411 (Implement subscript-assignment for NDArray) in a different way than described in the issue. There is ***no*** implementation to handle overlapping at the moment. Things like ```python xs = np_array([1, 2, 3, 4, 5, 6]) xs[::] = xs[::-1] ``` have undefined behavior at this moment because the current implementation is a naive `memcpy` from the source to the destination. I think an addition to fix this after `ndstrides` is completed should be fine. `ScalarOrNDArray` is a utility to deal with implementing ndarray-related logics that deals with both scalars and ndarrays simultaneously.
lyken added 2 commits 2024-08-28 14:08:10 +08:00
lyken added a new dependency 2024-08-28 14:11:36 +08:00
#520 ndstrides: [10] Reimplement binops, unary ops, and cmpops.
lyken force-pushed ndstrides-9-subassign from ccc8ce5886 to cea512456a 2024-08-30 14:55:09 +08:00 Compare
lyken commented 2024-08-30 14:55:14 +08:00
Author
Collaborator
Copy Link

Rebased.

Rebased.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b ndstrides-9-subassign ndstrides-8-transpose
git pull origin ndstrides-9-subassign

Step 2:

Merge the changes and update on Gitea.
git checkout ndstrides-8-transpose
git merge --no-ff ndstrides-9-subassign
git push origin ndstrides-8-transpose
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#520 ndstrides: [10] Reimplement binops, unary ops, and cmpops.
M-Labs/nac3
Depends on
#518 ndstrides: [8] implement `np_transpose()` (with no axes argument)
M-Labs/nac3
Reference: M-Labs/nac3#519
No description provided.
Delete Branch "ndstrides-9-subassign"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?