ndstrides: [9] Implement ndarray subscript assignment #519

lyken · 2024-08-28T14:08:10+08:00

lyken commented

2024-08-28 14:08:10 +08:00

Implemented general ndarray subscript assignment with referential integrity.

For example, you can do funky things like np_transpose(np_transpose(my_array)[::3])[0, 2:100] = 1.0 and my_array would update. This is only possible with ndarray with strides.
Solves #411 (Implement subscript-assignment for NDArray) in a different way than described in the issue.

There is no implementation to handle overlapping at the moment. Things like

xs = np_array([1, 2, 3, 4, 5, 6])
xs[::] = xs[::-1]

have undefined behavior at this moment because the current implementation is a naive memcpy from the source to the destination. I think an addition to fix this after ndstrides is completed should be fine.

ScalarOrNDArray is a utility to deal with implementing ndarray-related logics that deals with both scalars and ndarrays simultaneously.

Implemented general ndarray subscript assignment with referential integrity. - For example, you can do funky things like `np_transpose(np_transpose(my_array)[::3])[0, 2:100] = 1.0` and `my_array` would update. This is only possible with ndarray with strides. - Solves https://git.m-labs.hk/M-Labs/nac3/issues/411 (Implement subscript-assignment for NDArray) in a different way than described in the issue. There is ***no*** implementation to handle overlapping at the moment. Things like ```python xs = np_array([1, 2, 3, 4, 5, 6]) xs[::] = xs[::-1] ``` have undefined behavior at this moment because the current implementation is a naive `memcpy` from the source to the destination. I think an addition to fix this after `ndstrides` is completed should be fine. `ScalarOrNDArray` is a utility to deal with implementing ndarray-related logics that deals with both scalars and ndarrays simultaneously.

lyken added 2 commits 2024-08-28 14:08:10 +08:00

48ce2d6c8a

core/ndstrides: add more ScalarOrNDArray and NDArrayObject utils

ccc8ce5886

core/ndstrides: implement subscript assignment

lyken added a new dependency 2024-08-28 14:08:14 +08:00

#518 ndstrides: [8] implement `np_transpose()` (with no axes argument)

lyken added a new dependency 2024-08-28 14:11:36 +08:00

#520 ndstrides: [10] Reimplement binops, unary ops, and cmpops.

lyken force-pushed ndstrides-9-subassign from ccc8ce5886 to cea512456a

2024-08-30 14:55:09 +08:00

Compare