ndstrides: [6] Implement np_reshape() #516

lyken · 2024-08-28T13:59:10+08:00

lyken commented

2024-08-28 13:59:10 +08:00

Reimplemented np_reshape(), in IRRT.

np_reshape() can reshape an ndarray without making a copy of the data, under certain conditions.
(Partially) solves issue: #278 (ndarray: Implement reshaping). See below for why this is "partial".

NOTE: In NumPy, np.reshape(<ndarray>) may or may not make a copy depending on if a reshape is "possible". Currently, NAC3's criterion is by simply checking NDArrayObject::is_c_contiguous() to decide whether or not to make a copy by playing around with the ndarray stride values, this is certainly different from how NumPy works.

Reimplemented `np_reshape()`, in IRRT. - `np_reshape()` can reshape an ndarray without making a copy of the data, under certain conditions. - (Partially) solves issue: https://git.m-labs.hk/M-Labs/nac3/issues/278 (ndarray: Implement reshaping). See below for why this is "partial". NOTE: In NumPy, `np.reshape(<ndarray>)` may or may not make a copy depending on if a reshape is "possible". Currently, NAC3's criterion is by simply checking `NDArrayObject::is_c_contiguous()` to decide whether or not to make a copy by playing around with the ndarray stride values, this is certainly different from how NumPy works.

lyken added 2 commits 2024-08-28 13:59:10 +08:00

core: categorize np_{transpose,reshape} as 'view functions' 48d7032b5e

core/ndstrides: implement np_reshape() 813dad4ed0

lyken added a new dependency 2024-08-28 13:59:15 +08:00

#515 ndstrides: [5] Implement `np_{identity,eye,shape,strides,size}` and `ndarray.{fill.copy}`

lyken changed title from ~~ndstrides-6-reshape~~ to ndstrides: [6] Implement `np_reshape()`

2024-08-28 13:59:33 +08:00

lyken added a new dependency 2024-08-28 14:02:36 +08:00

#517 ndstrides: [7] implement broadcasting & `np_broadcast_to()`

lyken force-pushed ndstrides-6-reshape from 813dad4ed0 to 09fec5efaf

2024-08-30 14:37:55 +08:00

Compare