M-Labs/nac3
M-Labs/nac3
8
1
Fork 13
Code Issues 100 Pull Requests 5 Releases Wiki Activity

ndstrides: [4] Implement np_array() #514

Closed
lyken wants to merge 4 commits from ndstrides-4-nparray into ndstrides-3-indexing
pull from: ndstrides-4-nparray
merge into: M-Labs:ndstrides-3-indexing
Conversation 3 Commits 4 Files Changed 10 +461 -45
lyken commented 2024-08-28 13:51:23 +08:00
Collaborator
Copy Link

Reimplemented np_array() + Proper assertions when the input is a list (e.g., raise an exception when the list has inhomogeneous dimensions).

However, currently only np_array(<input>, copy=False) and np_array(<input>, copy=True) are supported.In NumPy, copy could be false, true, or None. Right now with this PR, NAC3's np_array(<input>, copy=False) behaves like NumPy's np.array(<input>, copy=None). Fortunately this should be easy to implement.

Reimplemented `np_array()` + Proper assertions when the input is a list (e.g., raise an exception when the list has inhomogeneous dimensions). However, currently only `np_array(<input>, copy=False)` and `np_array(<input>, copy=True)` are supported.In NumPy, copy could be `false`, `true`, or `None`. Right now with this PR, NAC3's `np_array(<input>, copy=False)` behaves like NumPy's `np.array(<input>, copy=None)`. Fortunately this should be easy to implement.
lyken added 4 commits 2024-08-28 13:51:23 +08:00 
Needed for implementing np_array()
It also checks for inconsistent dimensions if the input is a list.
e.g., rejecting `[[1.0, 2.0], [3.0]]`.
lyken added a new dependency 2024-08-28 13:52:09 +08:00
#513 ndstrides: [3] Implement indexing/slicing
lyken force-pushed ndstrides-4-nparray from b158ec80b4 to 81e937db82 2024-08-30 14:26:13 +08:00 Compare
lyken commented 2024-08-30 14:28:03 +08:00
Author
Collaborator
Copy Link

Rebased.

Rebased.
lyken force-pushed ndstrides-4-nparray from 81e937db82 to f109c58da8 2024-08-30 14:38:34 +08:00 Compare
lyken commented 2024-08-30 14:38:48 +08:00
Author
Collaborator
Copy Link

Rebased to fix some formatting issues.

Rebased to fix some formatting issues.
lyken force-pushed ndstrides-4-nparray from f109c58da8 to d222236492 2024-08-30 14:40:19 +08:00 Compare
derppening force-pushed ndstrides-4-nparray from d222236492 to de732ba68e 2024-10-17 14:27:57 +08:00 Compare
derppening force-pushed ndstrides-4-nparray from de732ba68e to 2c3463c516 2024-10-17 16:10:37 +08:00 Compare
derppening force-pushed ndstrides-4-nparray from 2c3463c516 to 6234060e85 2024-10-17 16:31:18 +08:00 Compare
derppening force-pushed ndstrides-4-nparray from 6234060e85 to 8f0084ac8a 2024-10-18 14:23:46 +08:00 Compare
derppening commented 2025-01-06 16:50:15 +08:00
Collaborator
Copy Link

Superseded by #568.

Superseded by #568.
derppening closed this pull request 2025-01-06 16:50:15 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#515 ndstrides: [5] Implement `np_{identity,eye,shape,strides,size}` and `ndarray.{fill.copy}`
M-Labs/nac3
Depends on
#513 ndstrides: [3] Implement indexing/slicing
M-Labs/nac3
Reference: M-Labs/nac3#514
No description provided.
Delete Branch "ndstrides-4-nparray"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?