[core] Fix resolution of exception names in raise short form #507

derppening · 2024-08-26T14:30:02+08:00

derppening commented

2024-08-26 14:30:02 +08:00

Previous implementation fails as resolver.get_identifier_def in ARTIQ
would return the exception init function rather than the class.

We fix this by limiting the exception class resolution to only include
raise statements, and to force the exception name to always be treated
as a class.

Fixes #501.

Previous implementation fails as `resolver.get_identifier_def` in ARTIQ would return the exception __init__ function rather than the class. We fix this by limiting the exception class resolution to only include raise statements, and to force the exception name to always be treated as a class. Fixes #501.

derppening added 1 commit 2024-08-26 14:30:03 +08:00

552dbc02f1 [core] Fix resolution of exception names in raise short form

Previous implementation fails as `resolver.get_identifier_def` in ARTIQ
would return the exception __init__ function rather than the class.

We fix this by limiting the exception class resolution to only include
raise statements, and to force the exception name to always be treated
as a class.

Fixes #501.

derppening requested review from sb10q 2024-08-26 14:30:06 +08:00

sb10q merged commit 2b2b2dbf8f into master

2024-08-26 18:35:02 +08:00

sb10q deleted branch fix/issue-501

2024-08-26 18:35:03 +08:00

Sign in to join this conversation.

No reviewers