M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 97 Pull Requests 20 Releases Wiki Activity

core/typecheck: fix np_array ndmin bug #490

Merged
sb10q merged 1 commits from np_array_bug into master 2024-08-13 15:02:20 +08:00
Conversation 0 Commits 1 Files Changed 1 +5 -3
lyken commented 2024-08-13 12:54:40 +08:00
Collaborator
Copy Link

This typechecks but shouldn't:

my_arr: ndarray[float, 1] = np_array([[1.0, 2.0, 3.0]], ndmin=1)
        ^^^^^^^^^^^^^^^^^
        should be ndarray[float, 2]

PR to fix.

This typechecks but shouldn't: ``` my_arr: ndarray[float, 1] = np_array([[1.0, 2.0, 3.0]], ndmin=1) ^^^^^^^^^^^^^^^^^ should be ndarray[float, 2] ``` PR to fix.
lyken added 1 commit 2024-08-13 12:54:41 +08:00
lyken requested review from derppening 2024-08-13 13:02:20 +08:00
sb10q merged commit 35a7cecc12 into master 2024-08-13 15:02:20 +08:00
sb10q deleted branch np_array_bug 2024-08-13 15:02:20 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
derppening
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#490
No description provided.
Delete Branch "np_array_bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?