M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

core: reduce code duplication in codegen/llvm_intrinsic #450

Merged
sb10q merged 2 commits from refactor-llvm_intrinsics into master 2024-07-09 16:30:32 +08:00
Conversation 0 Commits 2 Files Changed 1 +114 -538
abdul124 commented 2024-07-08 12:21:48 +08:00
Collaborator
Copy Link

Use macros to reduce code duplication in codegen/llvm_intrinsic

Use macros to reduce code duplication in `codegen/llvm_intrinsic`
abdul124 added 1 commit 2024-07-08 12:21:48 +08:00
abdul124 requested review from sb10q 2024-07-08 15:18:29 +08:00
sb10q reviewed 2024-07-09 04:48:22 +08:00
nac3core/src/codegen/llvm_intrinsics.rs Outdated
@ -317,0 +175,4 @@
/// Use `into_int_value` for Integer return type and `into_float_value` for Float return type
/// * `$llvm_ty:ident`: Type of first operand
/// * `,($val:ident)*`: Comma separated list of operands
macro_rules! helper_generate_llvm_intrinsic_fn_call {
sb10q commented 2024-07-09 04:48:22 +08:00
Owner
Copy Link

Remove "helper" and "call" terminology (also in comments, this is not generating a function call).

Remove "helper" and "call" terminology (also in comments, this is *not* generating a function call).
abdul124 commented 2024-07-09 10:48:39 +08:00
Author
Collaborator
Copy Link

Renamed macros to:

  1. generate_llvm_intrinsic_fn_body: Generates the llvm intrinsic build call (body of the call_llvm_intrinsic functions).
  2. generate_llvm_intrinsic_fn: Generates the function header and uses the macro generate_llvm_intrinsic_fn_body for function body.
Renamed macros to: 1) `generate_llvm_intrinsic_fn_body`: Generates the llvm intrinsic build call (body of the `call_llvm_intrinsic` functions). 2) `generate_llvm_intrinsic_fn`: Generates the function header and uses the macro `generate_llvm_intrinsic_fn_body` for function body.
abdul124 added 1 commit 2024-07-09 10:42:34 +08:00
sb10q merged commit 88b72af2d1 into master 2024-07-09 16:30:32 +08:00
sb10q deleted branch refactor-llvm_intrinsics 2024-07-09 16:30:33 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#450
No description provided.
Delete Branch "refactor-llvm_intrinsics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?