M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

core: improve function call errors #437

Merged
sb10q merged 2 commits from improve-call-errors into master 2024-06-27 14:06:56 +08:00
Conversation 1 Commits 2 Files Changed 3 +170 -74
lyken commented 2024-06-26 15:57:44 +08:00
Collaborator
Copy Link

Fixes #435. Details are documented the issue as well. All issues outlined there are fixed in this PR except for:

func1(23, 45, z = 67, z = 89) # ERROR: Keyword argument repeated: z
# nac3's parser panics when duplicate keywords are found, which I think is appropriate since Python considers this as a SyntaxError. Probably this is not an issue.
Fixes https://git.m-labs.hk/M-Labs/nac3/issues/435. Details are documented the issue as well. All issues outlined there are fixed in this PR except for: ``` func1(23, 45, z = 67, z = 89) # ERROR: Keyword argument repeated: z # nac3's parser panics when duplicate keywords are found, which I think is appropriate since Python considers this as a SyntaxError. Probably this is not an issue. ```
lyken requested review from derppening 2024-06-26 15:58:12 +08:00
derppening approved these changes 2024-06-26 18:35:43 +08:00
sb10q was assigned by derppening 2024-06-26 18:35:50 +08:00
lyken force-pushed improve-call-errors from ae48e2042d to 3958a9ccd8 2024-06-27 10:09:47 +08:00 Compare
lyken added 1 commit 2024-06-27 10:12:21 +08:00
lyken added a new dependency 2024-06-27 13:59:03 +08:00
#439 core: improve binop and cmpop error messages
sb10q commented 2024-06-27 14:05:53 +08:00
Owner
Copy Link

nac3's parser panics when duplicate keywords are found, which I think is appropriate since Python considers this as a SyntaxError. Probably this is not an issue.

It is not appropriate but not going to cause problems in ARTIQ since the source is parsed first by CPython before it is passed to nac3.

> nac3's parser panics when duplicate keywords are found, which I think is appropriate since Python considers this as a SyntaxError. Probably this is not an issue. It is not appropriate but not going to cause problems in ARTIQ since the source is parsed first by CPython before it is passed to nac3.
sb10q merged commit b21df53e0d into master 2024-06-27 14:06:56 +08:00
sb10q deleted branch improve-call-errors 2024-06-27 14:06:56 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
derppening
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sb10q
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#439 core: improve binop and cmpop error messages
M-Labs/nac3
Reference: M-Labs/nac3#437
No description provided.
Delete Branch "improve-call-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?